From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1127 invoked by alias); 6 Mar 2011 20:54:39 -0000 Received: (qmail 1114 invoked by uid 22791); 6 Mar 2011 20:54:38 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 Mar 2011 20:54:31 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 2B71A2F7800D for ; Sun, 6 Mar 2011 20:54:29 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4ATKEy3kBumA; Sun, 6 Mar 2011 20:54:27 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001114] New port: NXP LPC17XX Variant, Olimex LPC-1766-STK platform X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Sun, 06 Mar 2011 20:54:00 -0000 Message-Id: <20110306205427.A6C0F2F78006@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-03/txt/msg00002.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001114 --- Comment #29 from Ilija Kocho 2011-03-06 20:54:24 GMT --- (In reply to comment #28) > (In reply to comment #27) [snip] > I get it (however, it looks a bit encrypted :-). I admit :-/ > I have doubts about the > "modem" signals which were turned on by default. Do you really need to > activate them in the statrup code? About comments-memo, I would prefer > to have (diff against your delta) It's true, the modem signals are used very seldom, but they are wired on the platform board LPC-17XX-STK so I decided to enable them in order to reflect the hardware. However, if it may facilitate application of same platform port on other/custom boards we can omit them. For the time being I have no diff to post. Off topic: I can see that sometimes you make diffs against /dev/null. What diff option do you use? > > - // Enable UART0 and UART1 pins > - > - // Enable pins: TXD1. .. .. .. .. .. RXD0-TXD0 .. > - CYGHWR_HAL_LPC17XX_PIN_SET(CYGHWR_HAL_LPC17XX_REG_PINSEL0, 0x40000050); > - > - // Enable pins: .. .. .. .. .RTS1 .DTR1 DSR1-DCD1 CTS1-RXD1 > - CYGHWR_HAL_LPC17XX_PIN_SET(CYGHWR_HAL_LPC17XX_REG_PINSEL1, 0x00001155); > - > + // Enable UART0 and UART1 > + CYGHWR_HAL_LPC17XX_PIN_SET(CYGHWR_HAL_LPC17XX_REG_PINSEL0, > + (1 /* TXD0 */ << 4) | > + (1 /* RXD0 */ << 6) | > + (1 /* TXD1 */ << 30) > + ); > + CYGHWR_HAL_LPC17XX_PIN_SET(CYGHWR_HAL_LPC17XX_REG_PINSEL1, > + (1 /* RXD1 */ << 0) > + ); > > But, maybe someone will have alternative view (about "modem" signals). If you decide against modem signals, pse let me know and eventually attach a patch so I test it on my board. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.