From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6308 invoked by alias); 3 Apr 2011 22:37:59 -0000 Received: (qmail 6263 invoked by uid 22791); 3 Apr 2011 22:37:58 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 03 Apr 2011 22:37:53 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id A28EB2F78010 for ; Sun, 3 Apr 2011 23:37:51 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 31N-z-6etbWS; Sun, 3 Apr 2011 23:37:50 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001184] Cortex-m arch: hal_intr.h includes var_intr.h too early. X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Sun, 03 Apr 2011 22:37:00 -0000 Message-Id: <20110403223750.655B82F78003@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-04/txt/msg00009.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001184 --- Comment #3 from Ilija Kocho 2011-04-03 23:37:49 BST --- (In reply to comment #2) > (In reply on comment #0) > > Created an attachment (id=1195) --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1195) [details] > > Include var_intr.h after definition of hal_intr.h macros but allows > > overriding of CYGNUM_HAL_INTERRUPT_RTC. > > > > In Cortex-M architecture, the header hal_intr.h includes var_intr.h > > twice. Second one is of course with no effect, but the first one is > > too early. Namely some macros that are defined in hal_intr.h, such as > > CYGNUM_HAL_INTERRUPT_EXTERNAL, are used in hal-intr.h. This doesn't > > seem to show ill effect so far since usage is by other macros. > > > > Note: The early inclusion of var_intr.h has been introduced by Bug > > 1001090 Attachment 1092 [details] in order to enable overriding of > > CYGNUM_HAL_INTERRUPT_RTC by variant/platform. > > > > The proposed patch includes var_intr.h after definition of hal_intr.h > > macros but also allows overriding of CYGNUM_HAL_INTERRUPT_RTC. > > Thanks for catch. On my look CYGNUM_HAL_INTERRUPT_RTC definition became > misplaced lines via that request (no header, in fact). So, I would shift > down the definition and point on this on CL entry. Certainly, the first > inclusion of the header can be removed safely then. Thanks for the reply Sergei. As far as I understand you are going to revert hal_intr.h to state before Attachment 1092 and in addition shift CYGNUM_HAL_INTERRUPT_RTC definition after inclusion of var_intr.h. Am I right? It would fit, since var_intr.h shall be included after definition of Cortex-M system vectors and before CYGNUM_HAL_INTERRUPT_RTC. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.