From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 998 invoked by alias); 19 Aug 2011 08:41:10 -0000 Received: (qmail 982 invoked by uid 22791); 19 Aug 2011 08:41:07 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Aug 2011 08:40:50 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 65D4C2F78012 for ; Fri, 19 Aug 2011 09:40:49 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wPFTM5Ttv-fb; Fri, 19 Aug 2011 09:40:47 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001275] Cortex-M (armV7) architecture endian instructions / Applied on lwIP X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Fri, 19 Aug 2011 08:41:00 -0000 Message-Id: <20110819084047.4414F2F78003@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-08/txt/msg00006.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001275 --- Comment #5 from Ilija Kocho 2011-08-19 09:40:37 BST --- (In reply to comment #4) > (In reply to comment #3 from IK) > > (In reply to comment #2 from SG) > > > Instead hal_arch_instr.h I would create _regs.h header file to > > > define a few instructions in assembler. In your case it is > > > cortexm_regs.h. > > > > > > NOTE: There are the precendents of such definitions in other > > > architecture trees. > > > > > > > Right! Actually I was looking for such a header but obviously not hard > > enough. I would have been happier if file name was hal_regs.h, but > > let's not break the habit, and use cortexm_regs.h > > > > > I mean (snippets not tested!) > > > > > > #ifndef CYGONCE_HAL_CORTEXM_REGS_H > > > #define CYGONCE_HAL_CORTEXM_REGS_H > > > //==================================================== ... > > > // > > > // cortexm_regs.h > > > // > > > // Cortex-M CPU definitions > > > // > > > // ... > > > > > > #include > > > > > > #include > > > > > > // Macro to embed rev instructions in C code > > > #define CYGARC_REV(_origin_, _swapped_) \ > > > asm volatile( "rev %0, %1\n" \ > > > : "=r" (_swapped_) \ > > > : "r" (_origin_) \ > > > ); > > > > > > #define CYGARC_REV16(_origin_, _swapped_) \ > > > asm volatile( "rev16 %0, %1\n" \ > > > : "=r" (_swapped_) \ > > > : "r" (_origin_) \ > > > ); > > > > > > // We could also define the functions, now using macros. > > Then my question, Where did you plan to define and implement them? The idea was to have CMSIS like functions http://www.arm.com/products/processors/cortex-m/cortex-microcontroller-software-interface-standard.php in cortexm_regs.h, but I changed my mind so pse forget. > > > // In context with this please look at discussion > > // regarding lwIP below. > > // Regarding functions I have one dillema: > > // Could we rename cygarc_arm_rev*() functions into cygarc_byteswap*()? > > IMHO, as hal_endian.h contains > > #ifndef CYG_SWAP16 > # define CYG_SWAP16(_x_) > ... > > #ifndef CYG_SWAP32 > # define CYG_SWAP32(_x_) > ... > > And you would just define own versions (see below). > Agree. [snip] > > Ilija, Do you really need in C90 inline attribute? Do you really need > extern inlines. AFAIK, extern + inline is almost macro and what is about If I reconsider, not really. These functions are single instruction and compiler should be crazy not to inline. [snip] > > > // Platform supports endian operations. > > #define CYGARC_BYTESWAP 1 > > OK, or may be CYGARC_SWAPXX. > > > #define CYGARC_BYTESWAP32(__val) cygarc_arm_rev(__val) > > #define CYGARC_BYTESWAP16(__val) ((cyg_uint16)cygarc_arm_rev16(__val)) > > I would prefer those short names or may be even CYG_SWAP16, CYG_SWAP32; Personally I would like CYGARC_SWAPxx(), but since CYG_SWAPxx() are already present in hal_endian.h let's use them. It will propagate REV instructions in other parts of code that may benefit (i guess it is safe). > also I would not put the above definitions in cortexm_regs.h. In my > opinion CYGARC_SWAP16, CYGARC_SWAP32 can be placed in hal_arch.h. I am thinking this way too, only I didn't want to do lot's of changes in hal_arch.h. Now, especially if we use CYG_SWAPxx() it shouldn't be a problem. [snip] > Agreed. But, I told about some invented `hal_net.h' thought. Above and > below was for such a header. See below. IMHO this would need further consideration since as it is supposed to propagate through other architectures too. Likewise, I would be happy to have hal_devs.h, (actually var_devs.h) for HAL defines borrowed to devices (pin configurations, clock sources, power management etc). [snip] > > Ilija, IMHO > > 1) _regs.h is for registers, opcodes, mnemonics, and asm inlines > definitions. So, let's put a few CYGARC_REV* defines there for now. > Agree. > 2) We can define CYGARC_SWAPxx or CYG_SWAPxx macros and put there static > inlines for them in hal_arch.h. Agree. > > I would avoid C90 inline attributes (always_inline) in hal_arch.h as > it is GCC4-ish and I would quote here "one never knows what the next > annoying compiler will demand" :-) As mentioned before it should be safe to omit them, I'll re-confirm during my tests. > [snip] > > 3) If we will define SWAP16/32 in hal_arch.h then lwiopts.h can get > almost yours (just an example) > > #ifdef CYGARC_SWAPXX > # define LWIP_PLATFORM_BYTESWAP 1 > # define LWIP_PLATFORM_HTONS(__val) CYGARC_SWAP16(__val) > # define LWIP_PLATFORM_HTONL(__val) CYGARC_SWAP32(__val) > #endif Clear. > > Well, it is my view only. I hope that I did not miss something. Thanks again for considerations. At present I am away, but today I return home and I am going to test during weekend. FAOD, unless you object I intend to use CYG_SWAPxx() naming. Ilija -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.