From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16161 invoked by alias); 19 Aug 2011 15:09:45 -0000 Received: (qmail 16136 invoked by uid 22791); 19 Aug 2011 15:09:43 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Aug 2011 15:09:29 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id E6E922F78014 for ; Fri, 19 Aug 2011 16:09:27 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5a-cw3QPnXsM; Fri, 19 Aug 2011 16:09:26 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001275] Cortex-M (armV7) architecture endian instructions / Applied on lwIP X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: sergei.gavrikov@gmail.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Fri, 19 Aug 2011 15:09:00 -0000 Message-Id: <20110819150926.8A7952F78003@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-08/txt/msg00007.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001275 --- Comment #6 from Sergei Gavrikov 2011-08-19 16:09:22 BST --- (In reply to comment #5) > (In reply to comment #4) [ snip many lines where we came to consensus, see comment 4 ] > Personally I would like CYGARC_SWAPxx(), but since CYG_SWAPxx() are > already present in hal_endian.h let's use them. It will propagate REV > instructions in other parts of code that may benefit (i guess it is > safe). > > also I would not put the above definitions in cortexm_regs.h. In my > > opinion CYGARC_SWAP16, CYGARC_SWAP32 can be placed in hal_arch.h. > > I am thinking this way too, only I didn't want to do lot's of changes > in hal_arch.h. Now, especially if we use CYG_SWAPxx() it shouldn't be > a problem. So, we will not reinvent the weel and will stay on CYG_SWAPxx(). > > Well, it is my view only. I hope that I did not miss something. > > Thanks again for considerations. At present I am away, but today I > return home and I am going to test during weekend. FAOD, unless you > object I intend to use CYG_SWAPxx() naming. I vote for CYG_SWAPxx() too. I'm sorry but this week I'll be AFK. CYA -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.