From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14220 invoked by alias); 23 Aug 2011 14:18:46 -0000 Received: (qmail 14207 invoked by uid 22791); 23 Aug 2011 14:18:44 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Aug 2011 14:18:30 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id E87AB2F7800C for ; Tue, 23 Aug 2011 15:18:28 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DVMaI3Btb48Y; Tue, 23 Aug 2011 15:18:26 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001275] Cortex-M (armV7) architecture endian instructions / Applied on lwIP X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: sergei.gavrikov@gmail.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Tue, 23 Aug 2011 14:18:00 -0000 Message-Id: <20110823141825.C58DE2F78004@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-08/txt/msg00019.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001275 --- Comment #18 from Sergei Gavrikov 2011-08-23 15:18:22 BST --- (In reply to comment #16) > (In reply to comment #15) > > > I will very appreciate your final patches for lwipopts.h, and config > > files. > > Here's what I got today. > > Cortex-M CDL: Disabling CYGIMP_HAL_ARCH_ENDIAN also suppresses > generation of cortexm_endian.h so we have somplete global wipe-out. > > --- ecos/packages/hal/cortexm/arch/current/cdl/hal_cortexm.cdl 2011-04-06 > 18:54:16.000000000 +0200 > +++ ecos_kin/packages/hal/cortexm/arch/current/cdl/hal_cortexm.cdl > 2011-08-23 14:54:14.000000000 +0200 > @@ -138,6 +138,19 @@ > Higher priorities are reserved for the DEBUG and SVC traps." > } > > + cdl_option CYGIMP_HAL_ARCH_ENDIAN { > + display "Architecture optimized endian functions" > + flavor bool > + default_value 1 > + description "..." > + > + define_proc { > + puts $::cdl_system_header \ > + "#define CYGBLD_HAL_ENDIAN_H " > + } > + } > + > cdl_option CYGBLD_LINKER_SCRIPT { > display "Linker script" > flavor data > > lwIP CDL (lwipopt.h changed accordingly): > > --- ecos/packages/net/lwip_tcpip/current/cdl/lwip_net.cdl 2011-03-17 > 12:40:35.000000000 +0100 > +++ ecos_kin/packages/net/lwip_tcpip/current/cdl/lwip_net.cdl 2011-08-23 > 13:06:35.000000000 +0200 > @@ -127,6 +127,17 @@ > compile ecos/sio.c > } > > + cdl_option CYGIMP_LWIP_ENDIAN_BY_HAL { > + display "HAL optimized endian functions" > + flavor bool > + active_if CYGIMP_HAL_ARCH_ENDIAN > + default_value CYGIMP_HAL_ARCH_ENDIAN > + > + description "..." > + } > + > cdl_component CYGPKG_LWIP_APIS { > display "APIs" > flavor none Ilija, for me these CDLs look great! IMHO, you picked clear names. > I tested following cases: > 1. CYGIMP_HAL_ARCH_ENDIAN absent (what we have in other architectures) > 2. CYGIMP_HAL_ARCH_ENDIAN disabled (global disable) > 3. CYGIMP_HAL_ARCH_ENDIAN enabled and CYGIMP_LWIP_ENDIAN_BY_HAL disabled > 4 Both CYGIMP_HAL_ARCH_ENDIAN and CYGIMP_LWIP_ENDIAN_BY_HAL enabled Many thanks for testing. > If you are happy, I would submit. Of course, please, submit your patch(es). Thank you, Sergei > > Ilija -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.