From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29621 invoked by alias); 27 Sep 2011 09:06:21 -0000 Received: (qmail 29592 invoked by uid 22791); 27 Sep 2011 09:06:18 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Sep 2011 09:06:00 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 03AE22F78011 for ; Tue, 27 Sep 2011 10:05:59 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0WRMzxc+eBpk; Tue, 27 Sep 2011 10:05:54 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001344] Allow nc_test_slave for lwIP to compile for targets with 128KiB RAM. X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: sergei.gavrikov@gmail.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Tue, 27 Sep 2011 09:06:00 -0000 Message-Id: <20110927090554.34B842F78004@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-09/txt/msg00005.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001344 --- Comment #5 from Sergei Gavrikov 2011-09-27 10:05:53 BST --- (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (In reply to comment #1) > > > > (In reply to comment #0) > > > > > Created an attachment (id=1377) --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1377) [details] [details] Reduce stack usage > of > > > > > nc_test_slave > > > > > > > > > > > Hi Ilija, > > > > > > > > I have one **minor** remark regarding attachment 1377 [details] [details]. > I > > > > would use ECHO_STACK_SIZE in the patch instead proposed name > > > > (TMAIN_STACK_SIZE), IMO, such "adjusted" names would look nicer > > > > > > Thanks for comment Sergei. > > > > > > I selected stack names to reflect thread names. Regarding your > > > proposal I assume that you mean MAIN_STACK_SIZE => ECHO_STACK_SIZE > > > rather than TMAIN..., aren't you? > > > > Hmm. I see > > > > @@ -748,7 +750,7 @@ > > 0, // entry parameter > > "socket echo test", // Name > > &stack[0], // Stack > > - STACK_SIZE, // Size > > + TMAIN_STACK_SIZE, // Size > > &thread_handle, // Handle > > &thread_data // Thread data structure > > ); > > > > So, I've meant s/TMAIN/ECHO/. > > OK. I see, diff doesn't show complete entry. The thread entry function is named > tmain. Here it is: > > // Create a main thread, so we can run the scheduler and have time 'pass' > cyg_thread_create(10, // Priority > tmain, // entry > 0, // entry parameter > "socket echo test", // Name > &stack[0], // Stack > TMAIN_STACK_SIZE, // Size > &thread_handle, // Handle > &thread_data // Thread data structure > ); > cyg_thread_resume(thread_handle); // Start it > > And tmain() doesn't do any echoing, it merely inits lwIP and starts thread > "main" - entry point net_test(). "main" performs echoing and that's why I > thought you were refering to MAIN_STACK_SIZE. > Anyway, now I see that I was not fully consistent. Maybe I should put > TEST_STACK_SIZE instead of MAIN_STACK_SIZE. Then we shall have: > > TEST_STACK_SIZE > LOAD_STACK_SIZE > IDLE_STACK_SIZE > TMAIN_STACK_SIZE > > What do you mean? Stupid me. Of course diff -u5 would avoid my "renaming" as I did not look on the test's source (it's bad thing from my side). I take aside my request. I'm sorry that I waste your time. Now all clear fo me. Sergei -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.