public inbox for ecos-patches@sourceware.org
 help / color / mirror / Atom feed
* [Bug 1001351] Non-dummy stm32_get_config() and stm32_set_config() for stm32 spi driver
       [not found] <bug-1001351-104@http.bugs.ecos.sourceware.org/>
@ 2011-09-29 20:05 ` bugzilla-daemon
  2011-09-30  8:26 ` bugzilla-daemon
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2011-09-29 20:05 UTC (permalink / raw)
  To: ecos-patches

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001351

Ilija Stanislevik <ilijas@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ecos-patches@ecos.sourcewar
                   |                            |e.org
          Component|SPI                         |Patches and contributions

--- Comment #2 from Ilija Stanislevik <ilijas@siva.com.mk> 2011-09-29 21:05:26 BST ---
(In reply to comment #1)

> Can you please clarify the above? Is this driver tied to STM3210E-EVAL in some
> way?

It is tied to STM3210E-EVAL, but not exclusively. The driver concerned is
usable with any stm32 based platform.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1001351] Non-dummy stm32_get_config() and stm32_set_config() for stm32 spi driver
       [not found] <bug-1001351-104@http.bugs.ecos.sourceware.org/>
  2011-09-29 20:05 ` [Bug 1001351] Non-dummy stm32_get_config() and stm32_set_config() for stm32 spi driver bugzilla-daemon
@ 2011-09-30  8:26 ` bugzilla-daemon
  2011-10-02 15:45 ` bugzilla-daemon
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2011-09-30  8:26 UTC (permalink / raw)
  To: ecos-patches

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001351

Ilija Stanislevik <ilijas@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1001351] Non-dummy stm32_get_config() and stm32_set_config() for stm32 spi driver
       [not found] <bug-1001351-104@http.bugs.ecos.sourceware.org/>
  2011-09-29 20:05 ` [Bug 1001351] Non-dummy stm32_get_config() and stm32_set_config() for stm32 spi driver bugzilla-daemon
  2011-09-30  8:26 ` bugzilla-daemon
@ 2011-10-02 15:45 ` bugzilla-daemon
  2011-10-03  8:12 ` bugzilla-daemon
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2011-10-02 15:45 UTC (permalink / raw)
  To: ecos-patches

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001351

--- Comment #3 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-10-02 16:45:31 BST ---
The patch looks good enough to commit. However, I would change CL
record, i.e. write something like:

  Add support for CYG_IO_{GET,SET}_CONFIG_SPI_CLOCKRATE.

IMO, "Non-dummy" looks excessively there.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1001351] Non-dummy stm32_get_config() and stm32_set_config() for stm32 spi driver
       [not found] <bug-1001351-104@http.bugs.ecos.sourceware.org/>
                   ` (2 preceding siblings ...)
  2011-10-02 15:45 ` bugzilla-daemon
@ 2011-10-03  8:12 ` bugzilla-daemon
  2011-10-03  8:14 ` bugzilla-daemon
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2011-10-03  8:12 UTC (permalink / raw)
  To: ecos-patches

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001351

Ilija Stanislevik <ilijas@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1381|0                           |1
        is obsolete|                            |

--- Comment #4 from Ilija Stanislevik <ilijas@siva.com.mk> 2011-10-03 09:11:52 BST ---
Created an attachment (id=1388)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1388)
Patch to spi_stm32.c and to ChangeLog.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1001351] Non-dummy stm32_get_config() and stm32_set_config() for stm32 spi driver
       [not found] <bug-1001351-104@http.bugs.ecos.sourceware.org/>
                   ` (3 preceding siblings ...)
  2011-10-03  8:12 ` bugzilla-daemon
@ 2011-10-03  8:14 ` bugzilla-daemon
  2011-10-03  9:38 ` bugzilla-daemon
  2013-05-01 20:09 ` bugzilla-daemon
  6 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2011-10-03  8:14 UTC (permalink / raw)
  To: ecos-patches

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001351

--- Comment #5 from Ilija Stanislevik <ilijas@siva.com.mk> 2011-10-03 09:13:44 BST ---
(In reply to comment #3)
> The patch looks good enough to commit. However, I would change CL
> record, i.e. write something like:
> 
>   Add support for CYG_IO_{GET,SET}_CONFIG_SPI_CLOCKRATE.
> 
> IMO, "Non-dummy" looks excessively there.

I agree with you, Sergei. The updated patch is included in Comment 4.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1001351] Non-dummy stm32_get_config() and stm32_set_config() for stm32 spi driver
       [not found] <bug-1001351-104@http.bugs.ecos.sourceware.org/>
                   ` (4 preceding siblings ...)
  2011-10-03  8:14 ` bugzilla-daemon
@ 2011-10-03  9:38 ` bugzilla-daemon
  2013-05-01 20:09 ` bugzilla-daemon
  6 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2011-10-03  9:38 UTC (permalink / raw)
  To: ecos-patches

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001351

--- Comment #6 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-10-03 10:38:25 BST ---
Now checked-in.

Thank you for your contribution to eCos.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1001351] Non-dummy stm32_get_config() and stm32_set_config() for stm32 spi driver
       [not found] <bug-1001351-104@http.bugs.ecos.sourceware.org/>
                   ` (5 preceding siblings ...)
  2011-10-03  9:38 ` bugzilla-daemon
@ 2013-05-01 20:09 ` bugzilla-daemon
  6 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2013-05-01 20:09 UTC (permalink / raw)
  To: ecos-patches

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001351

Ilija Stanislevik <ilijas@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |CURRENTRELEASE

--- Comment #7 from Ilija Stanislevik <ilijas@siva.com.mk> ---
This was checked-in long time ago. I guess I can safely close this bug.

Thank you John and Sergei.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2013-05-01 20:09 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-1001351-104@http.bugs.ecos.sourceware.org/>
2011-09-29 20:05 ` [Bug 1001351] Non-dummy stm32_get_config() and stm32_set_config() for stm32 spi driver bugzilla-daemon
2011-09-30  8:26 ` bugzilla-daemon
2011-10-02 15:45 ` bugzilla-daemon
2011-10-03  8:12 ` bugzilla-daemon
2011-10-03  8:14 ` bugzilla-daemon
2011-10-03  9:38 ` bugzilla-daemon
2013-05-01 20:09 ` bugzilla-daemon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).