From: bugzilla-daemon@bugs.ecos.sourceware.org
To: ecos-patches@ecos.sourceware.org
Subject: [Bug 1001219] Ethernet driver for STM32 connectivity line with port on MMstm32f107 board.
Date: Sat, 08 Oct 2011 14:27:00 -0000 [thread overview]
Message-ID: <20111008142726.C302E2F78006@mail.ecoscentric.com> (raw)
In-Reply-To: <bug-1001219-104@http.bugs.ecos.sourceware.org/>
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001219
--- Comment #4 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-08 15:27:25 BST ---
(In reply to comment #3)
> Hi Jerzy
>
> Thank you for your contribution. Here are my first remarks:
>
> 1. Some unresolved conflicts remain upon Propox board selection in Configtool
> and it may mislead the user that something is broken. It seems that Configtool
> can't resolve the CYGHWR_HAL_CORTEXM_STM32_CLOCK_PLL_SOURCE on it's own so
> let's make it little-bit easier:
> - Is it possible to re-arrange legal_values expression in order to make it
> easier for Configtool?
> - Or it is better to calculate default_value conditionally
> (CYGINT_HAL_CORTEXM_STM32_CL==0 ?)
>
> 2. CYGPKG_IO_ETH_DRIVERS is normally not included in the target. Not everybody
> would use Ethernet. Please remove it.
>
> 3. FYI, the PHY driver DP8348 has been resolved in meantime by Bug 1001235.
> Please synchronize your code with it.
4. Just one more thing: Won't it be better if Propox on-board chip member
appears (CYGHWR_HAL_CORTEXM_STM32) once this board is selected?
>
> Now some general hints: It usually takes a number of iterations before code is
> fit for commit and it would be easier for me (hopefully also for you) if you
> break the patch in several diffs (divide and conquer). Ideally - a diff for
> every affected package, in this case: /eth driver/, /variant/, /platform/ and
> eventually /phy driver/. As exception ecos.db is better not sent as diff,
> instead put your ecos.db entries in a plain file and name it ecos_db.txt .
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
next prev parent reply other threads:[~2011-10-08 14:27 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 22:11 [Bug 1001219] New: " bugzilla-daemon
2011-05-04 7:41 ` [Bug 1001219] " bugzilla-daemon
2011-05-12 9:18 ` bugzilla-daemon
2011-10-08 14:02 ` bugzilla-daemon
2011-10-08 14:27 ` bugzilla-daemon [this message]
2011-10-10 20:51 ` bugzilla-daemon
2011-10-10 20:54 ` bugzilla-daemon
2011-10-10 20:56 ` bugzilla-daemon
2011-10-10 21:13 ` bugzilla-daemon
2011-10-10 21:50 ` bugzilla-daemon
2011-10-11 19:53 ` bugzilla-daemon
2011-10-11 20:39 ` bugzilla-daemon
2011-10-11 21:08 ` bugzilla-daemon
2011-10-11 21:45 ` bugzilla-daemon
2011-10-12 11:25 ` bugzilla-daemon
2011-10-12 20:34 ` bugzilla-daemon
2011-10-12 21:15 ` bugzilla-daemon
2011-10-16 14:12 ` bugzilla-daemon
2011-10-16 14:12 ` bugzilla-daemon
2011-10-22 12:22 ` bugzilla-daemon
2011-10-23 21:27 ` bugzilla-daemon
2011-10-24 15:55 ` bugzilla-daemon
2011-12-04 21:22 ` bugzilla-daemon
2011-12-04 21:23 ` bugzilla-daemon
2011-12-04 21:24 ` bugzilla-daemon
2011-12-04 21:25 ` bugzilla-daemon
2011-12-04 21:35 ` bugzilla-daemon
2011-12-21 9:33 ` bugzilla-daemon
2011-12-26 21:47 ` bugzilla-daemon
2012-01-02 0:35 ` bugzilla-daemon
2012-01-06 23:53 ` bugzilla-daemon
2012-01-06 23:56 ` bugzilla-daemon
2012-01-06 23:57 ` bugzilla-daemon
2012-01-06 23:57 ` bugzilla-daemon
2012-01-07 0:02 ` bugzilla-daemon
2012-01-07 22:31 ` bugzilla-daemon
2012-01-09 14:19 ` bugzilla-daemon
2012-02-02 21:44 ` bugzilla-daemon
2012-02-03 13:20 ` bugzilla-daemon
2012-12-10 22:33 ` bugzilla-daemon
2012-12-21 20:02 ` bugzilla-daemon
2012-12-24 17:31 ` bugzilla-daemon
2012-12-24 21:46 ` bugzilla-daemon
2012-12-25 11:34 ` bugzilla-daemon
2012-12-27 17:45 ` bugzilla-daemon
2012-12-28 14:15 ` bugzilla-daemon
2013-01-01 21:09 ` bugzilla-daemon
2013-01-01 21:10 ` bugzilla-daemon
2013-01-01 21:11 ` bugzilla-daemon
2013-01-01 21:17 ` bugzilla-daemon
2013-01-01 21:22 ` bugzilla-daemon
2013-01-15 21:26 ` bugzilla-daemon
2013-01-15 21:27 ` bugzilla-daemon
2013-01-15 21:29 ` bugzilla-daemon
2013-01-20 21:47 ` bugzilla-daemon
2013-02-07 15:06 ` bugzilla-daemon
2013-02-07 18:05 ` bugzilla-daemon
2013-02-16 21:55 ` bugzilla-daemon
2013-04-01 17:28 ` bugzilla-daemon
2013-04-01 18:25 ` bugzilla-daemon
2013-04-06 22:43 ` bugzilla-daemon
2013-04-08 18:48 ` bugzilla-daemon
2013-04-09 11:03 ` bugzilla-daemon
2013-04-09 12:14 ` bugzilla-daemon
2013-04-12 11:12 ` bugzilla-daemon
2013-04-14 23:40 ` bugzilla-daemon
2013-04-17 21:34 ` bugzilla-daemon
2013-04-17 21:48 ` bugzilla-daemon
2017-02-15 7:40 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111008142726.C302E2F78006@mail.ecoscentric.com \
--to=bugzilla-daemon@bugs.ecos.sourceware.org \
--cc=ecos-patches@ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).