From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28407 invoked by alias); 17 Oct 2011 03:23:06 -0000 Received: (qmail 28373 invoked by uid 22791); 17 Oct 2011 03:23:04 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Oct 2011 03:22:42 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 64B642F78013 for ; Mon, 17 Oct 2011 04:22:41 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K38tOXBbzGe3; Mon, 17 Oct 2011 04:22:39 +0100 (BST) From: bugzilla-daemon@ecoscentric.com To: ecos-patches@ecos.sourceware.org Subject: [Issue 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet) X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: jifl@ecoscentric.com X-Bugzilla-Status: NEEDINFO X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC In-Reply-To: References: X-Bugzilla-URL: http://bugzilla.ecoscentric.com/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Mon, 17 Oct 2011 03:23:00 -0000 Message-Id: <20111017032239.B08772F78006@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-10/txt/msg00033.txt.bz2 Please do not reply to this email. Use the web interface provided at: https://bugzilla.ecoscentric.com/show_bug.cgi?id=1001187 Jonathan Larmour changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jifl@ecoscentric.com --- Comment #20 from Jonathan Larmour 2011-10-17 04:22:32 BST --- As per direct mail, here's a few comments, although I haven't done what I'd call a full review: - I'll just mention that if extra TTYs are justified, then you should just modify CYGPKG_IO_SERIAL. - "familly" should be spelt "family", and "acces" -> "access" - CDL display names shouldn't really end in full-stops ("."). The best way to decide what to use for display names is to think of what would be best in the graphical configuration tool - even if you, like many maintainers, don't use it, lots of eCos users do. - Various components which are "flavor none" should also have "no_define". - The CYGPKG_HAL_CORTEXM_KINETIS .cdl file is quite big - perhaps the components related to clocking could be split off into a separate file, and included. - This bit in hal_diag.c: +#if defined(CYGOPT_HAL_KINETIS_DIAG_IN_MISC_FLASH_SECTION) && \ + CYGOPT_HAL_KINETIS_DIAG_IN_MISC_FLASH_SECTION +# define CYGOPT_HAL_KINETIS_DIAG_FLASH_SECTION_ATTR \ + CYGOPT_HAL_KINETIS_MISC_FLASH_SECTION_ATTR +#else +# define CYGOPT_HAL_KINETIS_DIAG_FLASH_SECTION_ATTR +#endif I think you originally meant to begin that with: +#if defined(CYGOPT_HAL_KINETIS_DIAG_IN_MISC_FLASH_SECTION) && \ + CYGOPT_HAL_KINETIS_MISC_FLASH_SECTION_ATTR But given the CDL you can probably just use: #ifdef CYGOPT_HAL_KINETIS_DIAG_IN_MISC_FLASH_SECTION Nothing else leapt out at me. It seems a very good quality patch from what I can tell. Jifl -- Configure issuemail: https://bugzilla.ecoscentric.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the issue.