From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10357 invoked by alias); 17 Oct 2011 22:25:40 -0000 Received: (qmail 10341 invoked by uid 22791); 17 Oct 2011 22:25:38 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Oct 2011 22:25:24 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id D410D2F78013 for ; Mon, 17 Oct 2011 23:25:23 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xcKUkdSgPvFK; Mon, 17 Oct 2011 23:25:18 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet) X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: NEEDINFO X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Date: Mon, 17 Oct 2011 22:25:00 -0000 Message-Id: <20111017222518.81B372F78004@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-10/txt/msg00037.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=3D1001187 --- Comment #23 from Ilija Kocho 2011-10-17 23:25:15 B= ST --- Hi Sergei Thank you for jumping in. (In reply to comment #21) > Jifl> Nothing else leapt out at me. It seems a very good quality patch > Jifl> from what I can tell. >=20 > Totally agree. That's very solid code. It looks great. >=20 > Nothing of importance can add. Only if view under a microscope :-) Perfection is when there's nothing to take out. (Antoine de Saint-Exup=C3=A9ry) >=20 > Infusoria: >=20 > Ilija, if you will send some corrections, also, you would get rid the > trailing whitespaces (mostly in CDL) and expand a few tabs in ethernet Recently I have installed a macro in my editor [me] that removes trailing whitespace prior to saving. I hope new files shall come cleaner. > driver, also, I would get rid such shorthands >=20 > }while(need_service); I will try to find more appropriate term. Maybe: "need_delivery" "pending_delivery"... >=20 > there. And >=20 > wallclock: > +# Date: 2011.04.23 Changed. CU Ilija --=20 Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=3Demail ------- You are receiving this mail because: ------- You are on the CC list for the bug.