From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20923 invoked by alias); 22 Oct 2011 12:22:02 -0000 Received: (qmail 20902 invoked by uid 22791); 22 Oct 2011 12:21:59 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 22 Oct 2011 12:21:43 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 5CFDE2F78007 for ; Sat, 22 Oct 2011 13:21:42 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G6sN8+yW+BHB; Sat, 22 Oct 2011 13:21:39 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001219] Ethernet driver for STM32 connectivity line with port on MMstm32f107 board. X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: ilijak@siva.com.mk X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Sat, 22 Oct 2011 12:22:00 -0000 Message-Id: <20111022122139.4A3332F78003@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-10/txt/msg00041.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001219 --- Comment #19 from Ilija Kocho 2011-10-22 13:21:29 BST --- (In reply to comment #5) > Created an attachment (id=1394) --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1394) [details] > Ethernet driver for STM32 CL > > Ethernet driver for STM32 Connectivity Line Some comments on Ethernet driver: MII and RMII interfaces are mutually exclusive and CDL should reflect this. A cdl_option with legal values "RMII" "MII" would provide it and in addition make it visible in configtool. "Remap pins" could be also visible if it were cdl_option. Regarding pins, some addition to my statement in Comment #11. Since pins are being provided by HAL, they should be defined in HAL (unlike other Ethernet definitions such as registers, etc.). Preferable place is plf_io.h rather than var_io.h. because other chips (present or future) may have different pin mapping. On the other hand, the pin functions - once assigned to Ethernet (although pins are provided provided by HAL) belong to Ethernet so their naming should reflect this Here is a plf_io.h snuppet: plf_io.h snippet -------------------------------- #define CYGHWR_IO_ETH_STM32MAC_MII_COL \ CYGHWR_HAL_STM32_GPIO(A, 3, IN , FLOATING) ... ------------------------------------------------- Also if_stm32.c Could CYGHWR_HAL_STM32_GPIO_SET(CYGHWR_...); lines be replaced by a loop? And in order to avoid specifying HAL specific macros in a device driver, a new macro can be defined CYGHWR_IO_ETH_STM32MAC_PIN(...). Note: In macro names above I arbitrarily put "STM32MAC" segment. Probably there is a more appropriate name for this Ethernet controller. CYGNUM_DEVS_ETH_CORTEXM_STM32_RX_BUFS: Is there a range of legal values? BTW other Ethernet devices that I have seen also provide configuration option for TX_BUFFS.Is this fixed on STM32 Ethernet controller? TCP/IP Checksum generation and check. FYI lwIP is aware of such hardware features http://sourceware.org/ml/ecos-discuss/2011-07/msg00017.html and it would be good if they are implemented. Ilija -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.