From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32568 invoked by alias); 26 Nov 2011 10:57:42 -0000 Received: (qmail 32559 invoked by uid 22791); 26 Nov 2011 10:57:42 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 26 Nov 2011 10:57:27 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id C4F672F78011 for ; Sat, 26 Nov 2011 10:57:25 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k-VZAro8t0T1; Sat, 26 Nov 2011 10:57:23 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001388] Convenience macros for manipulating GPIO pins X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: normal X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Sat, 26 Nov 2011 10:57:00 -0000 Message-Id: <20111126105722.E0D1E2F78004@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-11/txt/msg00019.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388 --- Comment #3 from Ilija Kocho 2011-11-26 10:57:18 GMT --- Tomas There's not much gain by abbreviation /*_PT?_P/ vs /*_PORT?_P/. IMO, in general and when possible, it would be convenient if names resemble the ones used in Kinetis RM: such as CLEAR (vs UNSET). FYI, you can find some convenient general macros for bit manipulation and masking in arch/current/include/hal/io /BIT_(), MASK_(), VALUE_()/ Having these macros, the set would be (more) complete with addition of macros for configuring of port bits /pddr/. For future (to do) we may consider complementary inline functions with pointer to a port as first argument. Ilija -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.