public inbox for ecos-patches@sourceware.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugs.ecos.sourceware.org
To: ecos-patches@ecos.sourceware.org
Subject: [Bug 1001291] New HAL for Cortex-M3 Smartfusion device
Date: Sat, 03 Dec 2011 15:48:00 -0000	[thread overview]
Message-ID: <20111203154746.E479C2F78003@mail.ecoscentric.com> (raw)
In-Reply-To: <bug-1001291-104@http.bugs.ecos.sourceware.org/>

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001291

--- Comment #27 from Ilija Kocho <ilijak@siva.com.mk> 2011-12-03 15:47:39 GMT ---
Chhristophe

Thank you for the updates. I tried configuration with default template
(Ethernet driver diff not patched yet).

jifl, have we interpretation from FSF regarding STM disclaimer exception on
networking stacks?

As expected configtool raises warning for missing Ethernet driver, otherwise
creation of build tree proceedes without problem.

However building process raises following warnings (default tpl no changes):

.../spi_a2fxxx.c:466: warning: ‘a2fxxx_transaction_begin’ defined but not used
.../spi_a2fxxx.c:554: warning: ‘a2fxxx_transaction_transfer’ defined but not
used
.../spi_a2fxxx.c:568: warning: ‘a2fxxx_transaction_tick’ defined but not used
.../spi_a2fxxx.c:583: warning: ‘a2fxxx_transaction_end’ defined but not used
.../spi_a2fxxx.c:608: warning: ‘a2fxxx_get_config’ defined but not used
.../spi_a2fxxx.c:614: warning: ‘a2fxxx_set_config’ defined but not used
.../spi_a2fxxx.c:218: warning: ‘a2fxxx_spi_bus_setup’ defined but not used

As expected warnings disappear when a spi bus is enabled, I guess you know what
to do.

Reading spi_a2fxxx.c I have also noticed that you are using \ for extension of
normal (non macro) lines. I would ask you to remove them since some editors
(such as MicroEmacs put warning on such lines.
Also some lines are much longer than famous 78 char boundary (example line 386)
I would ask you to also check other files for similar issues.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

  parent reply	other threads:[~2011-12-03 15:48 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-20 21:01 [Bug 1001291] New: " bugzilla-daemon
2011-07-20 21:02 ` [Bug 1001291] " bugzilla-daemon
2011-07-20 21:03 ` bugzilla-daemon
2011-07-20 21:03 ` bugzilla-daemon
2011-07-20 21:04 ` bugzilla-daemon
2011-07-20 21:05 ` bugzilla-daemon
2011-07-20 21:05 ` bugzilla-daemon
2011-07-20 21:06 ` bugzilla-daemon
2011-07-20 21:07 ` bugzilla-daemon
2011-07-20 21:09 ` bugzilla-daemon
2011-07-20 21:11 ` bugzilla-daemon
2011-07-20 21:20 ` bugzilla-daemon
2011-07-23 11:36 ` bugzilla-daemon
2011-07-26 12:47 ` bugzilla-daemon
2011-10-12 22:05 ` bugzilla-daemon
2011-10-13  7:22 ` bugzilla-daemon
2011-10-13 16:37 ` bugzilla-daemon
2011-11-10  4:33 ` bugzilla-daemon
2011-11-11 16:37 ` bugzilla-daemon
2011-11-11 16:40 ` bugzilla-daemon
2011-11-11 17:48 ` bugzilla-daemon
2011-11-14  0:28 ` bugzilla-daemon
2011-11-14  8:33 ` bugzilla-daemon
2011-11-14 22:05 ` bugzilla-daemon
2011-11-14 22:31 ` bugzilla-daemon
2011-11-20 13:35 ` bugzilla-daemon
2011-11-20 13:38 ` bugzilla-daemon
2011-12-03 15:48 ` bugzilla-daemon [this message]
2011-12-03 16:50 ` bugzilla-daemon
2011-12-18 16:25 ` bugzilla-daemon
2011-12-18 16:25 ` bugzilla-daemon
2011-12-18 16:26 ` bugzilla-daemon
2011-12-18 16:27 ` bugzilla-daemon
2011-12-18 16:28 ` bugzilla-daemon
2011-12-18 16:28 ` bugzilla-daemon
2011-12-18 16:29 ` bugzilla-daemon
2011-12-18 16:30 ` bugzilla-daemon
2011-12-18 16:33 ` bugzilla-daemon
2012-01-02 18:39 ` bugzilla-daemon
2012-01-07 14:23 ` bugzilla-daemon
2012-01-07 14:37 ` bugzilla-daemon
2012-01-07 22:45 ` bugzilla-daemon
2012-01-07 23:10 ` bugzilla-daemon
2012-01-07 23:22 ` bugzilla-daemon
2012-01-08  8:49 ` bugzilla-daemon
2012-02-10 13:24 ` bugzilla-daemon
2012-02-12 10:16 ` bugzilla-daemon
2012-02-12 12:16 ` bugzilla-daemon
2012-02-13  1:39 ` bugzilla-daemon
2012-02-26 11:26 ` bugzilla-daemon
2012-02-26 11:26 ` bugzilla-daemon
2012-02-26 11:30 ` bugzilla-daemon
2012-02-26 11:30 ` bugzilla-daemon
2012-02-26 11:31 ` bugzilla-daemon
2012-02-26 11:33 ` bugzilla-daemon
2012-02-28 17:48 ` bugzilla-daemon
2012-02-28 17:49 ` bugzilla-daemon
2012-03-07 21:48 ` bugzilla-daemon
2012-03-07 21:50 ` bugzilla-daemon
2012-03-07 21:51 ` bugzilla-daemon
2012-03-07 21:52 ` bugzilla-daemon
2012-03-07 21:53 ` bugzilla-daemon
2012-03-07 21:55 ` bugzilla-daemon
2012-03-07 22:00 ` bugzilla-daemon
2012-03-12 18:36 ` bugzilla-daemon
2012-03-12 22:10 ` bugzilla-daemon
2012-03-13 19:07 ` bugzilla-daemon
2012-03-13 20:24 ` bugzilla-daemon
2012-03-31 14:38 ` bugzilla-daemon
2012-04-01  8:04 ` bugzilla-daemon
2012-04-01  9:07 ` bugzilla-daemon
2012-04-01 19:37 ` bugzilla-daemon
2013-02-12 20:41 ` bugzilla-daemon
2017-02-15  7:18 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111203154746.E479C2F78003@mail.ecoscentric.com \
    --to=bugzilla-daemon@bugs.ecos.sourceware.org \
    --cc=ecos-patches@ecos.sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).