From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29550 invoked by alias); 21 Dec 2011 12:05:58 -0000 Received: (qmail 29532 invoked by uid 22791); 21 Dec 2011 12:05:54 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Dec 2011 12:05:41 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 0AF4E2FB0827 for ; Wed, 21 Dec 2011 12:05:40 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vSdD-oaHLais; Wed, 21 Dec 2011 12:05:38 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001428] Hal bits for Kinetis K40 SLCD controller X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: tf+bugs.ecos@r-finger.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Wed, 21 Dec 2011 12:05:00 -0000 Message-Id: <20111221120538.357DF2F78005@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-12/txt/msg00034.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001428 --- Comment #2 from Tomas Frydrych 2011-12-21 12:05:36 GMT --- (In reply to comment #1) Thanks Ilija, > Regarding device drivers and HAL: In eCos terms, "HAL" refers to software > associated with CPU and hardware close to it. Therefore devices are not > considered part of HAL. Sure, but I thought the patches I have submitted maintain that distinction. Are you saying the on-chip SLCD controller should be treated as a device rather than part of the MCU? (Which I can do, of course.) > I am trying to make drivers as much as possible independent of Kinetis HAL and > one aspect is name space. Namely, for device naming I have used FREESCALE stem > rather than KINETIS, DEV or IO instead of HAL. Also instead of using > /devs//cortexm I have used/crated /devs//freescale directories. > I would invite you to keep this conventions with hope that in future someone > may (wish to) use the drivers on Coldfire+ or PX. I did that for the MMA7660 patch (bug 1001419), for exactly the reasons you state; for the i2c driver I followed the conventions used by the driver I based it on. > Regarding register macros such as: > #define CYG_HAL_KINETIS_LCD_GCR \ > ((cyghwr_hal_kinetis_lcd_t*)CYG_HAL_KINETIS_LCD_B)->gcr > > IMO such macros tend to produce sub-optimal code and I wouldn't accept them. > Commonly, you need same pointer more than once within a function (to access > same or different structure member(s)) and it is more effective to declare a > pointer and (re)use it. OK, I can remove these. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.