From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21693 invoked by alias); 23 Dec 2011 14:14:24 -0000 Received: (qmail 21666 invoked by uid 22791); 23 Dec 2011 14:14:23 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Dec 2011 14:12:11 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 7BEF32F78014 for ; Fri, 23 Dec 2011 14:12:10 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UPN0WHRDoFR2; Fri, 23 Dec 2011 14:12:09 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001397] I2C driver for Kinetic microcontrollers X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Fri, 23 Dec 2011 14:14:00 -0000 Message-Id: <20111223141209.045452F78005@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-12/txt/msg00048.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001397 --- Comment #5 from Ilija Kocho 2011-12-23 14:12:07 GMT --- (In reply to comment #3) > In the light of the discussion in bug 1001428, I think the hal bits in this > patch should be moved under hal/misc/freescale/i2c? (In reply to comment #3) > In the light of the discussion in bug 1001428, I think the hal bits in this > patch should be moved under hal/misc/freescale/i2c? I assume you are referring to i2c header. They should stay with driver source, either in driver .c file or (preferably) in a header. As there is existing devs/i2c directory, I propose following path: - devs/i2c/freescale/ where is the name of this particular freescale spi instance (typically as referred to in ref. man.). Besides the device structure itself, there is some information provided by HAL (base address(es), pin configuration or so. They can be be considered variant or platform dependent and so defined in var_io_devs.h and/or plf_io.h respectively. If defined in both then plf shall override var. I hope in future to produce some docs but in meantime pse refer to ENET driver for example. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.