From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29934 invoked by alias); 2 Jan 2012 00:35:25 -0000 Received: (qmail 29829 invoked by uid 22791); 2 Jan 2012 00:35:24 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Jan 2012 00:35:11 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 7849C2F7800C for ; Mon, 2 Jan 2012 00:35:10 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y57FbouHAWb8; Mon, 2 Jan 2012 00:35:03 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001219] Ethernet driver for STM32 connectivity line with port on MMstm32f107 board. X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: ilijak@siva.com.mk X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Attachment #1475 is obsolete In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Mon, 02 Jan 2012 00:35:00 -0000 Message-Id: <20120102003503.17BB32F78008@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2012-01/txt/msg00002.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001219 Ilija Kocho changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #1475|0 |1 is obsolete| | --- Comment #29 from Ilija Kocho 2012-01-02 00:34:50 GMT --- (From update of attachment 1475) Thank you for the update Jerzy. I have checked building for default template with added Ethernet and lwIP - seems proper. Note: Just to state, there are some warnings that seem to be from old code - not a matter for this bug. Now we need little finish: Missing ChangeLog entries for Variant and SPI remapping patches. Please add. Copyright banners for driver and platform probably go too far in the past. I take it that this is essentially new code (especially the driver) and copyright message should reflect the fact. And little clean up. There is a little trailing whitespace and some macros in Variant have trailing semicolons ";" (look arround line 415). I guess they shouldn't be. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.