From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12886 invoked by alias); 11 Jan 2012 20:33:00 -0000 Received: (qmail 12878 invoked by uid 22791); 11 Jan 2012 20:32:59 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Jan 2012 20:32:46 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 901C33F70004 for ; Wed, 11 Jan 2012 20:32:44 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uVpO2LI-cDrP; Wed, 11 Jan 2012 20:32:41 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001397] I2C driver for Kinetic microcontrollers X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Wed, 11 Jan 2012 20:33:00 -0000 Message-Id: <20120111203241.1A44D2F78001@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2012-01/txt/msg00051.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001397 --- Comment #11 from Ilija Kocho 2012-01-11 20:32:34 GMT --- Hi Tomas, thank you for the update and here are my first notes: ISR priority Cortex-M NVIC implements priority arbitration with most significant /n/ bits implemented. Consequently in Kinetis (4 bits) they are bits 7..4 so priorities range 0x00, 0x10,..,0xf0. But this is not end of the story for eCos. Please visit this thread for full explanation (both references and follow-ups): http://ecos.sourceware.org/ml/ecos-devel/2010-11/msg00007.html It would be good to have configurable ISR priority. I understand that some drivers do not provide such control, but IMO that ISR priority manipulation may be important for tuning system behavior. And it is just a cdl per bus. I2C buses It would be good that unused buses are inactive - not present. Then user (or higher level I2C driver) activates the necessary bus by implementing respective interface. Also some parameters such as speed should be private to the bus. I can imagine two devices using separate buses at different speeds simultaneously. Also we don't need 2 init functions. Instead you can place parameters such as CYGHWR_IO_I2C_FREESCALE_I2Cx_PIN_SDA, etc. in the bus structure (or some const if you wish to save some RAM). Ilija -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.