From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32487 invoked by alias); 19 Jan 2012 20:46:22 -0000 Received: (qmail 32462 invoked by uid 22791); 19 Jan 2012 20:46:15 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Jan 2012 20:46:02 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 3F6EE2F7800B for ; Thu, 19 Jan 2012 20:46:01 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0jj9VzktsQlQ; Thu, 19 Jan 2012 20:45:59 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001453] CAN IO package: wider flags field, flag to report return to 'error active' mode X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: sergei.gavrikov@gmail.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Thu, 19 Jan 2012 20:46:00 -0000 Message-Id: <20120119204559.787742F78009@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2012-01/txt/msg00061.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001453 --- Comment #8 from Sergei Gavrikov 2012-01-19 20:45:54 GMT --- (In reply to comment #7) > Yet more needed change: > > - since flags will be 32 bits wide, then the flag_mask field in > cyg_can_callback_cfg_st must be expanded too. Must do a typedef (or a > #define?) for flags instead of using cyg_uint32, I missed the > flag_mask expansion because of this. > > - in can_callbacks_t, describing the function pointers accessible to > the low level drivers, xmt_msg is today: > > void (*xmt_msg)(can_channel *chan, void *pdata) > > I'd like to have instead: [snip] So far only one comment. Still try to be very careful when planning to change generic CAN I/O API. There is not only a dependence (LPC2XXX). % ecosconfig list | grep DEVS_CAN Package CYGPKG_DEVS_CAN_AT91SAM7 (AT91SAM7 CAN device drivers): Package CYGPKG_DEVS_CAN_LOOP (Loop CAN device drivers): Package CYGPKG_DEVS_CAN_LPC2XXX (LPC2xxx CAN device drivers): Package CYGPKG_DEVS_CAN_MCF52xx_FLEXCAN (MCF52xx FlexCAN device drivers): Sergei -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.