From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29880 invoked by alias); 24 Jan 2012 19:25:44 -0000 Received: (qmail 29832 invoked by uid 22791); 24 Jan 2012 19:25:43 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Jan 2012 19:25:27 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 465C815189C6 for ; Tue, 24 Jan 2012 19:25:26 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ppMENEkBk7yf; Tue, 24 Jan 2012 19:25:24 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001453] CAN IO package: wider flags field, flag to report return to 'error active' mode X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: bernard.fouche@kuantic.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Date: Tue, 24 Jan 2012 19:25:00 -0000 Message-Id: <20120124192524.A54D315189BD@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2012-01/txt/msg00062.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=3D1001453 --- Comment #9 from Bernard Fouch=C3=A9 2012-0= 1-24 19:25:16 GMT --- (In reply to comment #8) > > So far only one comment. >=20 > Still try to be very careful when planning to change generic CAN I/O > API. There is not only a dependence (LPC2XXX). >=20 > % ecosconfig list | grep DEVS_CAN > Package CYGPKG_DEVS_CAN_AT91SAM7 (AT91SAM7 CAN device drivers): > Package CYGPKG_DEVS_CAN_LOOP (Loop CAN device drivers): > Package CYGPKG_DEVS_CAN_LPC2XXX (LPC2xxx CAN device drivers): > Package CYGPKG_DEVS_CAN_MCF52xx_FLEXCAN (MCF52xx FlexCAN device drivers= ): >=20 > Sergei I've seen this. The only change that impacts other packages is the CYGNUM_CAN_EVENT_OVERRUN_RX event. Today this event has two meaning: 1) because the eCos RX queue is overwritt= en by a new message 2) a hardware related overrun. So when the event occurs, o= ne can't know if it's because the receive queue is undersized (or the applicat= ion is to slow to empty the queue), or if the driver isn't fast enough to proce= ss CAN bus activity, which is very different. So I've made a CYGNUM_CAN_EVENT_OVERRUN_RX_HW event for the second case. I've modified the AT91SAM7 and MCF52XX driver accordingly (one line is patc= hed just to change the name of the event since this event is generated only in = one place. Since all CAN drivers have been written by Uwe Kindler and follow the same logic it's easy to understand the code from a driver to the other). LPC2XXX driver I'll patch without my other changes, so every driver will be kept coherent with the CAN IO package. The loop driver does not require any change since it does not handle hardwa= re. Everything else I added is supported by older driver since it's just a matt= er of API convention defaulting to the set of features supported by older driv= ers. --=20 Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=3Demail ------- You are receiving this mail because: ------- You are on the CC list for the bug.