public inbox for
 help / color / mirror / Atom feed
Subject: [Bug 1001453] CAN IO package: wider flags field, flag to report return to 'error active' mode
Date: Thu, 26 Jan 2012 08:51:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Please do not reply to this email. Use the web interface provided at:

--- Comment #16 from Bernard Fouché <> 2012-01-26 08:50:35 GMT ---
(In reply to comment #15)
> [snip]
> > LPC2XXX driver I'll patch without my other changes, so every driver
> > will be kept coherent with the CAN IO package.
> I see. Sorry that you did not find volunteers that have the eCos CAN
> hardware.

Instead of updating the LPC2XXX CAN driver, I'll make a LPC17XX driver that can
still be compiled for LPC2XXX with a minimal amount of work. Anyway what stops
me to provide hardware drivers at this time is bug #1001456 since its solution
seems to be some API evolution regarding interrupt management, at least for
Cortex-M systems.

> By the way, we may on occasion remove all the warnings in builds of CAN
> tests. I found such annoying warnings (of course, they did exist before
> the patching):
>   cc1: warning: command line option "-Woverloaded-virtual" is valid for
> C++/ObjC++ but not for C
> Medicine: s/\$\(CFLAGS\)/$(ACTUAL_CFLAGS)/g for make rules in CAN config
> files
>   io/can/current/cdl/io_can.cdl
>   devs/can/m68k/mcf52xx/current/cdl/can_mcf52xx.cdl
>   devs/can/arm/lpc2xxx/current/cdl/can_lpc2xxx.cdl
> and may be this can be fixed in another patch-set. Your decision.

Why not wait after the release of the new toolchain? Maybe other compilation
flags will have to be updated in different places?

> Bernard, your work looks great for me. In particular, thank you for
> updated documentation.  I understand (agree with) your arguments. I
> plan to accept all changes after further testing, if nobody objects.

There is still something missing: having the application to be able to get the
values of TXREC/RXREC but this means more modifications to all hw drivers and
I'm not sure how to do this properly. Ideally the counter values would be
provided in events having flags raised like ERR_ACTIVE/ERR_PASSIVE, or they
could be made available by a call to _get_config(). The first solution would
increase the event size (could be an option at the CAN IO package level), the
second solution returns values that are already obsolete by the time the
application get them. So I'll leave this to the next volunteer ;-)

Configure bugmail:
------- You are receiving this mail because: -------
You are on the CC list for the bug.

  parent reply	other threads:[~2012-01-26  8:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-13 16:16 [Bug 1001453] New: " bugzilla-daemon
2012-01-13 16:17 ` [Bug 1001453] " bugzilla-daemon
2012-01-14 18:51 ` bugzilla-daemon
2012-01-14 22:40 ` bugzilla-daemon
2012-01-15 13:56 ` bugzilla-daemon
2012-01-15 22:30 ` bugzilla-daemon
2012-01-16  8:16 ` bugzilla-daemon
2012-01-18 21:48 ` bugzilla-daemon
2012-01-19 20:46 ` bugzilla-daemon
2012-01-24 19:25 ` bugzilla-daemon
2012-01-25 11:35 ` bugzilla-daemon
2012-01-25 11:39 ` bugzilla-daemon
2012-01-25 11:44 ` bugzilla-daemon
2012-01-25 11:45 ` bugzilla-daemon
2012-01-25 13:59 ` bugzilla-daemon
2012-01-25 20:07 ` bugzilla-daemon
2012-01-26  8:51 ` bugzilla-daemon [this message]
2012-02-06 10:00 ` bugzilla-daemon
2012-02-06 15:57 ` bugzilla-daemon
2012-02-06 20:30 ` bugzilla-daemon
2012-02-07  6:13 ` bugzilla-daemon
2012-02-09 21:46 ` bugzilla-daemon
2012-02-10 17:28 ` bugzilla-daemon
2012-02-11  4:16 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).