From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10861 invoked by alias); 26 Jan 2012 08:51:02 -0000 Received: (qmail 10836 invoked by uid 22791); 26 Jan 2012 08:51:00 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Jan 2012 08:50:47 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 20AE32F78001 for ; Thu, 26 Jan 2012 08:50:46 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sMOHVrOcmat7; Thu, 26 Jan 2012 08:50:44 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001453] CAN IO package: wider flags field, flag to report return to 'error active' mode X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: bernard.fouche@kuantic.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Date: Thu, 26 Jan 2012 08:51:00 -0000 Message-Id: <20120126085044.4D40E2F78005@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2012-01/txt/msg00073.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=3D1001453 --- Comment #16 from Bernard Fouch=C3=A9 2012-= 01-26 08:50:35 GMT --- (In reply to comment #15) > [snip] > > LPC2XXX driver I'll patch without my other changes, so every driver > > will be kept coherent with the CAN IO package. >=20 > I see. Sorry that you did not find volunteers that have the eCos CAN > hardware. Instead of updating the LPC2XXX CAN driver, I'll make a LPC17XX driver that= can still be compiled for LPC2XXX with a minimal amount of work. Anyway what st= ops me to provide hardware drivers at this time is bug #1001456 since its solut= ion seems to be some API evolution regarding interrupt management, at least for Cortex-M systems. > By the way, we may on occasion remove all the warnings in builds of CAN > tests. I found such annoying warnings (of course, they did exist before > the patching): >=20 > cc1: warning: command line option "-Woverloaded-virtual" is valid for > C++/ObjC++ but not for C >=20 > Medicine: s/\$\(CFLAGS\)/$(ACTUAL_CFLAGS)/g for make rules in CAN config > files >=20 > io/can/current/cdl/io_can.cdl > devs/can/m68k/mcf52xx/current/cdl/can_mcf52xx.cdl > devs/can/arm/lpc2xxx/current/cdl/can_lpc2xxx.cdl >=20 > and may be this can be fixed in another patch-set. Your decision. Why not wait after the release of the new toolchain? Maybe other compilation flags will have to be updated in different places? >=20 > Bernard, your work looks great for me. In particular, thank you for > updated documentation. I understand (agree with) your arguments. I > plan to accept all changes after further testing, if nobody objects. There is still something missing: having the application to be able to get = the values of TXREC/RXREC but this means more modifications to all hw drivers a= nd I'm not sure how to do this properly. Ideally the counter values would be provided in events having flags raised like ERR_ACTIVE/ERR_PASSIVE, or they could be made available by a call to _get_config(). The first solution would increase the event size (could be an option at the CAN IO package level), t= he second solution returns values that are already obsolete by the time the application get them. So I'll leave this to the next volunteer ;-) --=20 Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=3Demail ------- You are receiving this mail because: ------- You are on the CC list for the bug.