From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24113 invoked by alias); 26 Jan 2012 10:18:55 -0000 Received: (qmail 24102 invoked by uid 22791); 26 Jan 2012 10:18:53 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Jan 2012 10:18:40 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 92BC42FB085B for ; Thu, 26 Jan 2012 10:18:39 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Akjy17hH6Jl0; Thu, 26 Jan 2012 10:18:34 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001463] LPC17XX supplementary code/option patch X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Thu, 26 Jan 2012 10:18:00 -0000 Message-Id: <20120126101833.E9D992F78001@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2012-01/txt/msg00075.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001463 --- Comment #4 from Ilija Kocho 2012-01-26 10:18:32 GMT --- (In reply to comment #3) > (In reply to comment #2) > > Hi Bernard > > > > Thank you for your contribution. > > > > Past couple of days I have committed patches for Bug 1001395 (including bug > > 1001443) and Bug 1001432. You may need to synchronize your patches accordingly. > > I've first updated my copy of ecos-cvs before making the patch. More exactly I > was waiting for you to commit to make my patch ;-) > > > > > I could see that some patches cover issues reported (by you) in other bugs. Can > > you submit them there (and obsolete some patches of my own of course)? > > Splitting patches will speed up check in for some of them. > > You are probably referring to bug #1001407. Yes the proposed patch includes > changes similar to attachment 1481 [details] (however I didn't use the word 'omplemented' > in the comments ;-)) but it adds many more hardware related definitions. Maybe > you commit your patch, and then I'll submit a new one that won't have the same > fixes? At the moment I have chosen to make my diff vs the ecos cvs repo and I > don't consider pending patches. Maybe I should do differently? Since you have your focus on LPC17xx IMO you could do this fixes better than me. When you reported the discrepancies I wasn't aware that you are submitting copyright assignment, otherwise I would have asked you to propose patches. Now I would ask you to merge the fixes related to missing/wrong #defines. IMO the best place to submit this "super" patch is bug #1001407 since you can at the same time obsolete my patch. Also it will relief me from LPC17xx and shall give me more time for other jobs: GCC, etc... > > > > > Also, on your initiative we have started some discussion on bit banding at Bug > > 1001442 so we can continue there with your patches. > > So let's first decide how bitband is handled and afterwards I'll update the > proposed patch accordingly. Or I can remove the bitband macros in the proposed > patch. Your proposal could be a start point, sou you may re-submit macros at Bug 1001442. However, as I mentioned earlier, I would be happy with generic CORTEXM (or CORTEX_M) macros (where applicable) on architectural level. The headline of Bug 1001442 could be changed accordingly. Let's continue our discussion there. Ilija -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.