From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23141 invoked by alias); 12 Feb 2012 10:16:53 -0000 Received: (qmail 23133 invoked by uid 22791); 12 Feb 2012 10:16:52 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 12 Feb 2012 10:16:38 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 58F7B2F78003 for ; Sun, 12 Feb 2012 10:16:37 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pcrgfGWgkFGz; Sun, 12 Feb 2012 10:16:36 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001291] New HAL for Cortex-M3 Smartfusion device X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: ecos@hotmail.co.uk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: normal X-Bugzilla-Assigned-To: ilijak@siva.com.mk X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Sun, 12 Feb 2012 10:16:00 -0000 Message-Id: <20120212101636.1CE582F78004@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2012-02/txt/msg00033.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001291 --- Comment #46 from Christophe Coutand 2012-02-12 10:16:28 GMT --- Hi Ilija, I will check again the status of the new disclaimer and revert to you. However, I would like to fix Bug 1001449 first. I see in your attachment (Flash driver SST25XX SPI tests 120206) from Bug 1001450 that you have defined CYGNUM_DEVS_FLASH_SPI_SS25XX_MAP_ADDR directly in the test case (flash_sst25xx_test.c), instead of spreading CYGNUM_DEVS_FLASH_SPI_SST25XX_DEV0_MAP_ADDR. In my proposal (1001449), I suggested to have a platform specific include in the test case C file that provides the configuration of the platform flash: #include CYGDAT_DEVS_FLASH_SPI_AT25DFXXX_PLF_CDL And CYGDAT_DEVS_FLASH_SPI_AT25DFXXX_PLF_CDL is defined in the platform CDL as done other places: define_proc { puts $::cdl_system_header "#define CYGDAT_DEVS_FLASH_SPI_AT25DFXXX_PLF_CDL " } What do you think? Regards, Christophe -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.