From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24721 invoked by alias); 13 Feb 2012 01:39:06 -0000 Received: (qmail 24711 invoked by uid 22791); 13 Feb 2012 01:39:05 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Feb 2012 01:38:52 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 3059D2F7800A for ; Mon, 13 Feb 2012 01:38:51 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1D6yDte+PdAe; Mon, 13 Feb 2012 01:38:48 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001291] New HAL for Cortex-M3 Smartfusion device X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jifl@ecoscentric.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: normal X-Bugzilla-Assigned-To: ilijak@siva.com.mk X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Mon, 13 Feb 2012 01:39:00 -0000 Message-Id: <20120213013848.6EA082F78004@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2012-02/txt/msg00044.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001291 --- Comment #48 from Jonathan Larmour 2012-02-13 01:38:37 GMT --- (In reply to comment #46) > In my proposal (1001449), I suggested to have a platform specific include in > the test case C file that provides the configuration of the platform flash: > > #include CYGDAT_DEVS_FLASH_SPI_AT25DFXXX_PLF_CDL > > And CYGDAT_DEVS_FLASH_SPI_AT25DFXXX_PLF_CDL is defined in the platform CDL as > done other places: > > define_proc { > puts $::cdl_system_header "#define > CYGDAT_DEVS_FLASH_SPI_AT25DFXXX_PLF_CDL > " > } > > What do you think? Just a little thing but the naming of options like that should be something like CYGDAT_DEVS_FLASH_SPI_AT25DFXXX_PLF_H, not _CDL. Using _CDL might mislead some into thinking it has actual CDL in it, which obviously it doesn't. Jifl -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.