From: bugzilla-daemon@bugs.ecos.sourceware.org
To: ecos-patches@ecos.sourceware.org
Subject: [Bug 1001539] Single precision floating point math library
Date: Thu, 22 Mar 2012 18:05:00 -0000 [thread overview]
Message-ID: <20120322180536.CBC052F78005@mail.ecoscentric.com> (raw)
In-Reply-To: <bug-1001539-104@http.bugs.ecos.sourceware.org/>
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001539
--- Comment #20 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2012-03-22 18:05:34 GMT ---
(In reply to comment #19)
> > Tests expect NaN for out-of-domain arguments, but functions return
> > something else. For instance asinf(10) returns 0. Here is a little
> > example:
>
> IMO, it can depend on libm compatibility, look at libm compat.
> wrappers (w_*.c), e.g. at w_asin{,f}.c. Though, I think in our case
> it should be a result of call __ieee754_asin{,f}(). And if libm
> compat mode is not IEEE? I'm looking at misc/standard.c
> (__kernel_standard)...
Well, I understand what is wrong. Let's take `wf_asin.c', "i wonder"
hack:
--- a/packages/language/c/libm/current/src/float/ieee754-api/wf_asin.c
+++ b/packages/language/c/libm/current/src/float/ieee754-api/wf_asin.c
@@ -88,8 +88,10 @@
#ifdef CYGSEM_LIBM_COMPAT_IEEE_ONLY
return __ieee754_asinf(x);
#else
- double z;
+ float z;
z = __ieee754_asinf(x);
+ printf("__ieee754_asinf(%f)=%f\n", x, z);
+ return z;
if(cyg_libm_get_compat_mode() == CYGNUM_LIBM_COMPAT_IEEE || isnanf(x))
return z;
if(fabs(x)>1.0) {
return __kernel_standard(x,x,2); /* asin(|x|>1) */
Then let's run `asinf' (a picture worth more than many words)
INFO:<Still crunching, please wait...>
__ieee754_asinf(-1.200000)=nan
__ieee754_asinf(-1.190000)=nan
...
__ieee754_asinf(-1.010000)=nan
__ieee754_asinf(-1.000000)=-1.570796
...
__ieee754_asinf(0.000000)=0.000000
__ieee754_asinf(0.000000)=0.000000
INFO:<Still crunching, please wait...>
__ieee754_asinf(0.000000)=0.000000
PASS:<asinf() is stable>
EXIT:<Finished tests from testcase
/home/sg/repo/ecos-hg/packages/language/c/libm/current/tests/vectors/asinf.c
for Math library asinf() function>
Thus, IMHO, you have to implement own __kernel_standard_float() and
maybe another "float" wrappers to peace failed f-tests.
FYI, import
cdl_option CYGSEM_LIBM_COMPAT_IEEE_ONLY {
user_value 1
};
breaks build of single precision tests. Some your headers have EDOM
used, but this value is not defined for such config conditions. Perhaps,
you need weak definition for that in `vector_support_float.h' header.
// Not tested
#ifdef CYGSEM_LIBM_COMPAT_IEEE_ONLY
# ifndef EDOM
# define EDOM 33
# endif
#endif
Sergei
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
next prev parent reply other threads:[~2012-03-22 18:05 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 19:23 [Bug 1001539] New: " bugzilla-daemon
2012-03-20 19:24 ` [Bug 1001539] " bugzilla-daemon
2012-03-20 19:26 ` bugzilla-daemon
2012-03-20 19:39 ` bugzilla-daemon
2012-03-20 19:39 ` bugzilla-daemon
2012-03-20 19:40 ` bugzilla-daemon
2012-03-20 19:41 ` bugzilla-daemon
2012-03-20 19:43 ` bugzilla-daemon
2012-03-20 19:47 ` bugzilla-daemon
2012-03-21 13:44 ` bugzilla-daemon
2012-03-21 15:56 ` bugzilla-daemon
2012-03-21 18:36 ` bugzilla-daemon
2012-03-21 19:52 ` bugzilla-daemon
2012-03-22 10:24 ` bugzilla-daemon
2012-03-22 10:25 ` bugzilla-daemon
2012-03-22 10:26 ` bugzilla-daemon
2012-03-22 10:27 ` bugzilla-daemon
2012-03-22 10:28 ` bugzilla-daemon
2012-03-22 11:01 ` bugzilla-daemon
2012-03-22 13:42 ` bugzilla-daemon
2012-03-22 18:05 ` bugzilla-daemon [this message]
2012-03-22 23:53 ` bugzilla-daemon
2012-08-08 11:48 ` bugzilla-daemon
2013-05-15 20:00 ` bugzilla-daemon
2013-05-16 9:59 ` bugzilla-daemon
2013-06-07 9:17 ` bugzilla-daemon
2013-06-07 12:47 ` bugzilla-daemon
2013-06-07 20:20 ` bugzilla-daemon
2013-06-08 12:24 ` bugzilla-daemon
2013-06-08 15:37 ` bugzilla-daemon
2013-06-08 19:04 ` bugzilla-daemon
2013-06-08 19:08 ` bugzilla-daemon
2013-06-08 19:39 ` bugzilla-daemon
2013-06-09 9:39 ` bugzilla-daemon
2013-06-09 9:42 ` bugzilla-daemon
2013-06-09 18:23 ` bugzilla-daemon
2013-06-28 15:42 ` bugzilla-daemon
2013-06-28 15:44 ` bugzilla-daemon
2013-06-28 15:46 ` bugzilla-daemon
2013-06-28 15:51 ` bugzilla-daemon
2013-06-28 15:52 ` bugzilla-daemon
2013-06-28 15:53 ` bugzilla-daemon
2013-06-28 15:55 ` bugzilla-daemon
2013-06-28 15:56 ` bugzilla-daemon
2013-06-28 15:57 ` bugzilla-daemon
2013-06-28 15:58 ` bugzilla-daemon
2013-06-28 17:26 ` bugzilla-daemon
2013-08-09 15:44 ` bugzilla-daemon
2013-08-25 15:41 ` bugzilla-daemon
2013-09-24 18:08 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322180536.CBC052F78005@mail.ecoscentric.com \
--to=bugzilla-daemon@bugs.ecos.sourceware.org \
--cc=ecos-patches@ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).