From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26643 invoked by alias); 26 Mar 2012 16:11:29 -0000 Received: (qmail 26566 invoked by uid 22791); 26 Mar 2012 16:11:26 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Mar 2012 16:11:11 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 745132F7800D for ; Mon, 26 Mar 2012 17:11:10 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IgBd7P90mwUB; Mon, 26 Mar 2012 17:11:09 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001544] services/curses/pdcurses: porting to GCC 4.6 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: sergei.gavrikov@gmail.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Mon, 26 Mar 2012 16:11:00 -0000 Message-Id: <20120326161109.4F08A2F78003@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2012-03/txt/msg00120.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001544 --- Comment #3 from Sergei Gavrikov 2012-03-26 17:11:07 BST --- (In replay in comment #2) > As a patch to the current code, it is fine, please commit. Thanks for review, I'll process it. > This is a separate issue really, but when I looked at it, I thought > "that isn't thread-safe". But then I saw that it wasn't thread-safe > before either, and then I saw that the main pdcurses code isn't > thread-safe either. So I thought, that's fine, it's not meant to be > thread-safe, although that isn't clear in the documentation. > > But then I see examples/pdcecos_app.c which seems to create a bunch of > threads. But if curses isn't thread-safe, that doesn't seem like a > great idea. You're absolutely right. In those days I did not know that PDCurses is not thread safe (though and that serial driver is not thread-safe too). And now I even found a separate record about (in PDCurses HISTORY file) - Removed the PDC_THREAD_BUILD stuff, which has never worked. For the record: PDCurses is not thread-safe. Neither is ncurses; and the X/Open curses spec explicitly makes it a non-requirement. > In fact I don't really understand the purpose of pdcecos_app.c - why > would users need to start curses threads in a special and unusual way? > If it's just because of the need to create a per-thread data index, > then there are other ways that could be dealt with. I think it is better to remove that `example' folder, which can mislead someone else. So, I would remove that example in the next commit. I see that native PDcurses demos (or eCos PDCurses tests) are more than enough for the package. Thank you for your all points. Sergei > Jifl -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.