From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10330 invoked by alias); 1 Apr 2012 19:41:31 -0000 Received: (qmail 10321 invoked by uid 22791); 1 Apr 2012 19:41:31 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 01 Apr 2012 19:41:14 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 7F9162F7800C for ; Sun, 1 Apr 2012 20:41:13 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iGJWAm+AUMlA; Sun, 1 Apr 2012 20:41:12 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001550] STM32 F2 and STM3220G-EVAL / STM3240G-EVAL contribution from eCosCentric X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: john@dallaway.org.uk X-Bugzilla-Status: REOPENED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: jifl@ecoscentric.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status CC Resolution In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Sun, 01 Apr 2012 19:41:00 -0000 Message-Id: <20120401194111.DE1E92F78003@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2012-04/txt/msg00013.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001550 John Dallaway changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |john@dallaway.org.uk Resolution|NEXTRELEASE | --- Comment #9 from John Dallaway 2012-04-01 20:41:08 BST --- Jifl, great to see this contribution! Some initial comments/queries based on a quick scan of the patches: * An earlier patch to the STM32 serial driver for bug #1001068 appears to have been reversed by your patch. Can you reinstate this please? * Some of the changes listed in the STM3210E-EVAL platform HAL ChangeLog do not appear to be present in the source patch (eg the .ldi file changes). Can you check that the various ChangeLogs provide an accurate reflection of the changes committed please? Ref: http://bugs.ecos.sourceware.org/attachment.cgi?id=1684&action=diff * The ecos.db patch lists the STM32 ethernet and watchdog packages for the new targets and some relevant register definitions are provided at the HAL level but I don't see the packages in the CVS commit. Ref: http://bugs.ecos.sourceware.org/attachment.cgi?id=1683&action=diff#ecos.db_sec2 * The "set_value" keyword in ecos.db was introduced as a quick hack for use within the Red Hat test farm and was never intended to be used elsewhere. set_value will provide a user_value for the specified CDL item which can therefore be inadvertently changed using the "restore defaults" action in configtool. I would really like to consider the use of "set_value" to be deprecated. It should always be possible to use a separate tiny CDL-only package to achieve the same effect. Are you OK with this? Finally, are you able to confirm that the code you have checked in has been tested (eCos and RedBoot run-time) in the context of the eCos CVS HEAD? This is a substantial patch and I'm just concerned that we don't destabilise the existing STM32 support. Thanks -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.