From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26736 invoked by alias); 2 Apr 2012 15:56:00 -0000 Received: (qmail 26715 invoked by uid 22791); 2 Apr 2012 15:55:58 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Apr 2012 15:55:45 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 2ECEA2F78012 for ; Mon, 2 Apr 2012 16:55:44 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wc8sBFTWbbqJ; Mon, 2 Apr 2012 16:55:37 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001550] STM32 F2 and STM3220G-EVAL / STM3240G-EVAL contribution from eCosCentric X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: jifl@ecoscentric.com X-Bugzilla-Status: REOPENED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: jifl@ecoscentric.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Mon, 02 Apr 2012 15:56:00 -0000 Message-Id: <20120402155537.ABE2E2F78003@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2012-04/txt/msg00017.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001550 --- Comment #13 from Jonathan Larmour 2012-04-02 16:55:32 BST --- (In reply to comment #10) > Hi Jifl, can you integrate this contribution with the existing STM32 > contribution in bug #1001219 ? It seems that the Jerzy's contribution should > really have been checked in first to avoid conflicts. As far as I knew, that change was still work in progress, whereas this contribution was complete and finished. Were it otherwise, then I would expect Jerzy's contribution to have been committed, and at that point yes merging may have had to be considered for some portions. However looking at Jerzy's contribution, the STM32 variant changes in the eCosCentric contribution completely subsume and obsolete what Jerzy did, given this needs to provide both connectivity line *and* F2/F4 processor support, which changes clocking and pin mapping properties significantly, so the result would still have been something that looks identical or near-identical to this contribution. As for the Ethernet, it's up to Jerzy if he wants to use the definitions provided, or provide his own alternative in var_io_eth.h - at least a separate file keeps it all self-contained (var_io.h was getting too big to be navigable). All I would say is that eCosCentric's driver has undergone extensive testing using these definitions, so they are "known good", and has been used on multiple boards, and include necessary changed definitions for the F2/F4 which Jerzy's obviously wouldn't. And he will probably find the majority correspond exactly to what he's already got anyway since both the names and values essentially come from ST anyway. But yes, since an ethernet driver is not included in this contribution, Jerzy is free to use or ignore these definitions. They're there to be helpful, not to be an obstacle. Jifl -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.