[Bug 1001561] Internal flash driver for Freescale TWR-K60N512 board

[bugzilla-daemon@bugs.ecos.sourceware.org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001561

--- Comment #5 from Nicolas Aujoux <nau@csm-instruments.com> 2012-04-19 14:34:17 BST ---
Hi Ilija

I sent the e-mail requested for the copyright assignment and I am waiting for
their answer.

I updated the attachments :

- I move the common code to the variant level.

- I separated them as you recommended.

- I deleted the temporary files (sorry about that).

Also I figured out why I wasn't able to access some part of the flash. In fact
speculation logic and cache aliasing (which are enable by default) are not
supported on some tower boards. See there for more informations :
http://forums.freescale.com/t5/Kinetis-ARM-Cortex-M4/Accessing-the-FLASH-causing-BUS-fault/m-p/78873#M509

I added an option to disable these options in the cdl file. The driver should
now work properly.

Nicolas


(In reply to comment #1)
> (From update of attachment 1697 [details])
> Hi Nicolas
> 
> Thank you for your contribution, it would be nice to have Kinetis flash support
> in eCos.
> 
> In order to include your code in the official eCos repository we need your
> copyright assignment. Please visit http://ecos.sourceware.org/assign.html for
> explanation of the reasons for copyright assignment as well as the procedure
> instructions.
> 
> The copyright assignment process will take some time, but in meantime we can
> prepare your code for inclusion. Apart from notes below, I would start with
> code review as soon as you inform me that you have started with copyright
> assignment (that means you have sent materials to FSF).
> 
> Now some general notes on your flash driver:
> 
> 1. I imagine that all Kinetis parts have identical or similar Flash modules so
> the driver, especially code, should be common at variant level. Platforms then
> would mostly have configuration CDL.
> 
> 1.a. It would help if you break the patch in several files, typically: driver,
> variant, platform, ecos.db, etc). Regarding ecos.db it is sometimes better to
> submit packages as plain text file rather than diff.
> 
> 2. I can notice some temporary files left by your editor. Please try to keep
> your code clean.
> 
> That's all for now.
> 
> Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.