From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26117 invoked by alias); 11 Jul 2012 07:12:37 -0000 Received: (qmail 26106 invoked by uid 22791); 11 Jul 2012 07:12:35 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Jul 2012 07:12:23 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id D64AC2F780CA for ; Wed, 11 Jul 2012 08:12:21 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rGTzk2gYD2gh; Wed, 11 Jul 2012 08:12:20 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001561] Internal flash driver for Freescale TWR-K60N512 board X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: ilijak@siva.com.mk X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Wed, 11 Jul 2012 07:12:00 -0000 Message-Id: <20120711071220.587892F780C9@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2012-07/txt/msg00010.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001561 --- Comment #34 from Ilija Kocho 2012-07-11 08:12:14 BST --- Hi Jifl Thanks for comments. (In reply to comment #33) > Hi Nicolas, > > As well as Ilija's comments, I also have a few comments too before this is > committed: > [snip] . > > - I don't think the flash driver should be instantiated in kinetis_misc.c. It > should either go in kinetis_flash.c along with everything else, or go in > individual platform HALs, to allow them the ability to override or disable > (like the STM32 does with its internal flash driver). > FAOD I guess you are referring to devs/____/kinetis_flash.c . (Because there was a version with another kinetis_flash.c in HAL that contained only the flash driver entry. It was abandoned for reasons stated in comment #21). I vote for putting the driver entry with driver code since I don't see a need for different instances. Ilija -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.