From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9707 invoked by alias); 20 Jul 2012 11:26:01 -0000 Received: (qmail 9691 invoked by uid 22791); 20 Jul 2012 11:26:00 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Jul 2012 11:25:45 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 5ADE82F78018 for ; Fri, 20 Jul 2012 12:25:44 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NDFnG3O1975z; Fri, 20 Jul 2012 12:25:41 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001561] Internal flash driver for Freescale TWR-K60N512 board X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: ilijak@siva.com.mk X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Fri, 20 Jul 2012 11:26:00 -0000 Message-Id: <20120720112541.43E512F78001@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2012-07/txt/msg00023.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001561 --- Comment #40 from Ilija Kocho 2012-07-20 12:25:31 BST --- Hi Nicolas Thank you for the update. (In reply to comment #39) > (In reply to comment #38) > > Created an attachment (id=1832) --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1832) [details] [details] > > Hal part of the patch > > Hello Ilija and Jifl, > > I updated the two patches with some modifications (but not all) : > * I think I have made pretty much all the list of Jifl. > * I have made the modifications for the first point of Ilija (regarding flash > performance). For this feature, I had to create a flash_read function. > Otherwise, the flash was read without calling the kinetis flash driver and > therefore without the optimisation disabled, causing errors. Don't know if this > is the right way to do it but it works like that. It is actually a FMC _feature_ and there is a request that all writings in FMC registers be done by code _not_ executing in flash. Ref: a note in: / 27.4(K60) or 29.4(K70) Memory map and register descriptions /. I would replace "optimization" with "acceleration". "Optimization" may be associated with code optimizations - by compiler or handicraft while "acceleration" is widely used for hardware that speeds up execution of flashed code. Although FS doesn't use the term flash accelerator in their manuals Cortex-M users should be familiar (NXP, ST). If you lack a time for new patches I can do the changes. > > So there is still work to do on Ilija's point 2 and 3. Having in mind Jifl's comments probably point 2 can be put in TODO status. 3 too. > > As I told to Ilija, I will not be working in my current company anymore so I > will not be able to work on this project. > Nonetheless, others will work on this (notably Pierre-Jean Coudert, whom you > already spock with) and will ask for a copyright assignment if they need to. To be on a safe side, copyright assignment, especially employer's disclaimer, is recommended even for small patches and mandatory for substantial. Should you contribute in eCos from your new job, we shall need a disclaimer from your new employer. Once again, thank you for contributing to eCos and I wish you fun and success at your new job. Live long and prosper. Ilija -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.