public inbox for ecos-patches@sourceware.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugs.ecos.sourceware.org
To: ecos-patches@ecos.sourceware.org
Subject: [Bug 1001490] C99 snprintf() does not include terminated null in truncated strings
Date: Wed, 08 Aug 2012 07:31:00 -0000	[thread overview]
Message-ID: <20120808073048.ADE222F78005@mail.ecoscentric.com> (raw)
In-Reply-To: <bug-1001490-104@http.bugs.ecos.sourceware.org/>

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001490

--- Comment #4 from Bernd Edlinger <bernd.edlinger@hotmail.de> 2012-08-08 08:30:42 BST ---
(In reply to comment #3)
oops, sorry... Now I see, actually I applied the my own patch from
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001628
a while ago, it contained a new test case...

     // Check 7
     ret = snprintf(y, 20, "bit of that: %.4g double", 1.0012);
     my_strcpy(z, "bit of that: 1.001 ");
     CYG_TEST_PASS_FAIL(my_strcmp(y,z) == 0,
                        "snprintf double test #2");

     CYG_TEST_PASS_FAIL(ret == my_strlen(z),
                        "snprintf double test #2 return code");

when that did fail after applying your patch, I was surprised.

Well, there is more trouble with sprintf....

There is another bug #20804, about the %e format, that is also still
not fixed.

When I tried to understand, why that happens, I found a buffer overflow
in the statement: printf("%.15f", DBL_MAX);

There is a buffer in vfnprintf() which is 2 characters too small.
Maybe there should be a patch for all of the known issues.
What do you think?

Bernd.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

  parent reply	other threads:[~2012-08-08  7:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-19 13:11 [Bug 1001490] New: " bugzilla-daemon
2012-06-27 18:37 ` [Bug 1001490] " bugzilla-daemon
2012-08-07 10:06 ` bugzilla-daemon
2012-08-07 16:44 ` bugzilla-daemon
2012-08-08  7:31 ` bugzilla-daemon [this message]
2012-08-08 16:58 ` bugzilla-daemon
2012-08-09  7:50 ` bugzilla-daemon
2012-08-09  8:52 ` bugzilla-daemon
2012-08-09 10:00 ` bugzilla-daemon
2012-08-09 10:52 ` bugzilla-daemon
2012-08-09 11:04 ` bugzilla-daemon
2013-02-18 22:00 ` bugzilla-daemon
2013-02-19 10:40 ` bugzilla-daemon
2013-02-19 13:58 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120808073048.ADE222F78005@mail.ecoscentric.com \
    --to=bugzilla-daemon@bugs.ecos.sourceware.org \
    --cc=ecos-patches@ecos.sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).