From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14880 invoked by alias); 8 Aug 2012 18:01:35 -0000 Received: (qmail 14869 invoked by uid 22791); 8 Aug 2012 18:01:34 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Aug 2012 18:01:21 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 7013E2FB082B for ; Wed, 8 Aug 2012 19:01:20 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5o74sA59G8UF; Wed, 8 Aug 2012 19:01:15 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001607] Cortex-M4F architectural Floating Point Support X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: jifl@ecoscentric.com X-Bugzilla-Status: NEEDINFO X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: jifl@ecoscentric.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Wed, 08 Aug 2012 18:01:00 -0000 Message-Id: <20120808180115.42DD22F78005@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2012-08/txt/msg00020.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001607 --- Comment #20 from Jonathan Larmour 2012-08-08 19:01:08 BST --- Hi Ilija, (In reply to comment #18) > (In reply to comment #16) > >the part we are making temporary is the bit that says: > > requires { ("CYGHWR_HAL_CORTEXM == "M4") implies > > is_substr(!is_substr(CYGBLD_GLOBAL_CFLAGS, "-mcpu=cortex-m3") && > > is_substr(CYGBLD_GLOBAL_CFLAGS, " -mcpu=cortex-m4 ") } > > which instead we will comment out for now until we are happy with gcc 4.6.3. > > > > I agree about CYGOPT_HAL_CORTEXM4_CODE removal, but I think that making > -mcpu=cortex-m4 mandatory for M4 is too inflexible. With present CDL it is > possible to edit CYGBLD_GLOBAL_CFLAGS and change -mcpu. And somebody will want > to try M4 with cortex-m3 code. True enough, then we simply leave that 'requires' out forever rather than temporarily :-). > Therefore I think that the idea about CYGBLD_ARCH_XFLAGS is good. It will > provide -mcpu= default value which can later be edited. This will require us > to touch some platform CDL files but we only have to deal with M4 devices with > FPU and they are few (though we can see if we want to "canonize" other > platforms). Yes, better to do it now than later. > > All the M3-based platform HALs will have their CFLAGS default to > > -mcpu=cortex-m3, and the M4 HALs will have -mcpu=cortex-m4 -mfloat-abi=hard > > -mfpu=fpv4-sp-d16. > > FAOD, there are cortex-m4 devices without FPU as well. Sure, I just meant for our current TWR-K70 and STM3240G platforms. > We can apply following changes to CYGHWR_HAL_FPV4_SP_D16 [snip] > + requires { is_substr(CYGBLD_GLOBAL_CFLAGS, " -mcpu=cortexm4 > -mfloat-abi=hard -mfpu=fpv4-sp-d16") } > + requires { !is_substr(CYGBLD_GLOBAL_CFLAGS, "-mcpu=cortexm3") } > + requires { is_substr(CYGBLD_GLOBAL_LDFLAGS, " -mcpu=cortexm4 > -mfloat-abi=hard -mfpu=fpv4-sp-d16") } > + requires { !is_substr(CYGBLD_GLOBAL_LDFLAGS, "-mcpu=cortexm3") } Along with what was in the old "anti-flags" proposal to cover when it's disabled, that looks good. [snip] > > 5) I think CYGHWR_HAL_FPV4_SP_D16 can live under the CYGHWR_HAL_CORTEXM_FPU > > component. > > CYGHWR_HAL_FPV4_SP_D16 is a FPU instance. As you say in future there may be > others. Do we want them under CYGHWR_HAL_CORTEXM_FPU? Yes since they will all be active_if CYGHWR_HAL_CORTEXM_FPU anyway, they may as well just live under. > > 6) A general comment as something which can be done last thing before check-in, > > and I know it's only a cosmetic thing, but contents of options are a little > > more readable if things are aligned. For example: [snip] > > There are other places like this. My intention is to check them when we came > close to commit. Great, I'm just being paranoid then :-). Jifl -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.