public inbox for ecos-patches@sourceware.org
 help / color / mirror / Atom feed
* [Bug 1001716] New: MIPS malta + sead3 update
@ 2012-12-13  8:06 bugzilla-daemon
  2012-12-13 16:06 ` [Bug 1001716] " bugzilla-daemon
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: bugzilla-daemon @ 2012-12-13  8:06 UTC (permalink / raw)
  To: ecos-patches

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001716

           Summary: MIPS malta + sead3 update
           Product: eCos
           Version: 3.0
          Platform: malta_mips32_4kc (MIPS Malta board with Mips32 4Kc)
        OS/Version: MIPS
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: Patches and contributions
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: charleschiou@mips.com
                CC: ecos-patches@ecos.sourceware.org
             Class: Advice Request


Created an attachment (id=1998)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1998)
git diff d941400851050189750a0498b008cd6f2f51a8b3

- Update outdated drivers for proper hardware support on modern malta
- Support the SEAD3 board
- Retain compatibility with QEMU's malta emulator
- Support the newest mips-sde-elf-gcc toolchain (Sourcery CodeBench Lite
2012.03-64)
- Verified to still work with mipsisa32-elf-gcc toolchain (eCosCentric GNU
tools 4.3.2-sw)
- Support running eCos in MicroMIPS
- Verified to boot from Yamon and u-boot

Note: the diff is against the last commit of

commit d941400851050189750a0498b008cd6f2f51a8b3
Author: jld <none@none>
Date:   Thu Feb 3 16:44:50 2011 +0000

    * include/var_io.h: Fix CYGHWR_HAL_STM32_RCC_CFGR_PPRE2_* definitions.
      [ Bugzilla 1001137 ]

Comments and suggestions are welcome.

Thank you

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1001716] MIPS malta + sead3 update
  2012-12-13  8:06 [Bug 1001716] New: MIPS malta + sead3 update bugzilla-daemon
@ 2012-12-13 16:06 ` bugzilla-daemon
  2012-12-13 16:14 ` bugzilla-daemon
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2012-12-13 16:06 UTC (permalink / raw)
  To: ecos-patches

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001716

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
                 CC|                            |jifl@ecoscentric.com
     Ever Confirmed|0                           |1

--- Comment #1 from Jonathan Larmour <jifl@ecoscentric.com> 2012-12-13 16:06:22 GMT ---
Thanks for contributing back! The first thing that will be needed to allow this
to be checked in to the repository is a copyright assignment from MIPS to the
FSF. Please read http://ecos.sourceware.org/assign.html and fill in the form
linked from the there and submit it to the FSF.

In terms of the patch itself, a few things that stand out that would want
addressing, some are vital licensing issues, some are to match existing eCos
coding standard practice:

- You need ChangeLog entries for all changes

- New files should have the standard form of file banners at the start we use,
and in preparation for the assignment being completed should be marked as
Copyright the Free Software Foundation. Obviously, refer to any other files for
examples. The .ecm files, essentially being generated, can have their copyright
line removed.

- I suspect you would not want to assign copyright of msc01_pci.h to the FSF as
it comes from elsewhere. In which case it should still have a standard eCos
license/information banner at the beginning, but MIPS will also have to provide
a license which this file may be used under, which must be compatible with the
GPL. My suggestion would be either the GNU All-permissive license:

http://www.gnu.org/prep/maintain/html_node/License-Notices-for-Other-Files.html

or the modified BSD license:
http://directory.fsf.org/wiki/License:BSD_3Clause


- CYGPKG_MALTA_QEMU and CYGPKG_SEAD3 need descriptions.

- CYGPKG_IO_MALTA_SERIAL should be an option not a component.

- Naming of globals and functions should either have a cyg_ or hal_ prefix. For
example the functions uart_*, malta_*, arch_pci_config_access(), 

- Can you explain the change in memory address of mlt_mips_malta_ram.ldi ? If
nothing else, this will cause compatibility problems with existing ROM
monitors. Does it reflect a hardware change? If so, we would need existing
hardware to continue working.

- The use of uart2_channel looks a lot like a bodge. There are two serial
devices after all. I think this wants improvement. If you aren't able to do it
(short of time), it should be submitted into bugzilla as a bug report so the
issue is tracked and not forgotten.

- uart_debug and uart2_printf should be removed - standard HAL APIs should be
used instead.

- Is there really a need for the extra .ld files? Can't you just use ifdefs in
the normal mips_mips32.ld file?

That will do for a first pass of comments I think. We'll wait for the
assignment to come through before anything else.

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1001716] MIPS malta + sead3 update
  2012-12-13  8:06 [Bug 1001716] New: MIPS malta + sead3 update bugzilla-daemon
  2012-12-13 16:06 ` [Bug 1001716] " bugzilla-daemon
@ 2012-12-13 16:14 ` bugzilla-daemon
  2012-12-13 16:14 ` bugzilla-daemon
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2012-12-13 16:14 UTC (permalink / raw)
  To: ecos-patches

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001716

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1998|                            |assignment?(charleschiou@mi
               Flag|                            |ps.com), review-
   Attachment #1998|application/octet-stream    |text/plain
          mime type|                            |
   Attachment #1998|0                           |1
           is patch|                            |

--- Comment #2 from Jonathan Larmour <jifl@ecoscentric.com> 2012-12-13 16:13:45 GMT ---
(From update of attachment 1998)
Awaiting copyright assignment, and patch needs more work.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1001716] MIPS malta + sead3 update
  2012-12-13  8:06 [Bug 1001716] New: MIPS malta + sead3 update bugzilla-daemon
  2012-12-13 16:06 ` [Bug 1001716] " bugzilla-daemon
  2012-12-13 16:14 ` bugzilla-daemon
@ 2012-12-13 16:14 ` bugzilla-daemon
  2012-12-13 17:15 ` bugzilla-daemon
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2012-12-13 16:14 UTC (permalink / raw)
  To: ecos-patches

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001716

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned@bugs.ecos.source |jifl@ecoscentric.com
                   |ware.org                    |

--- Comment #3 from Jonathan Larmour <jifl@ecoscentric.com> 2012-12-13 16:14:07 GMT ---
Taking.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1001716] MIPS malta + sead3 update
  2012-12-13  8:06 [Bug 1001716] New: MIPS malta + sead3 update bugzilla-daemon
                   ` (2 preceding siblings ...)
  2012-12-13 16:14 ` bugzilla-daemon
@ 2012-12-13 17:15 ` bugzilla-daemon
  2012-12-25  7:44 ` bugzilla-daemon
  2013-06-03 13:43 ` bugzilla-daemon
  5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2012-12-13 17:15 UTC (permalink / raw)
  To: ecos-patches

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001716

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |john@dallaway.org.uk

--- Comment #4 from John Dallaway <john@dallaway.org.uk> 2012-12-13 17:15:43 GMT ---
Great to see this patch!

I would add that, since CYGPKG_MALTA_QEMU and CYGPKG_SEAD3 are hardware-related
CDL options, they should be named accordingly:

  CYGPKG_MALTA_QEMU -> CYGHWR_HAL_MIPS_MALTA_QEMU
  CYGPKG_SEAD3 -> CYGHWR_HAL_MIPS_MALTA_SEAD3

Similarly for the build-related option:

  CYGPKG_HAL_MIPS_MICROMIPS -> CYGBLD_HAL_MIPS_MICROMIPS

For a list of CDL option naming conventions:

http://ecos.sourceware.org/docs-latest/cdl-guide/language.naming.html

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1001716] MIPS malta + sead3 update
  2012-12-13  8:06 [Bug 1001716] New: MIPS malta + sead3 update bugzilla-daemon
                   ` (3 preceding siblings ...)
  2012-12-13 17:15 ` bugzilla-daemon
@ 2012-12-25  7:44 ` bugzilla-daemon
  2013-06-03 13:43 ` bugzilla-daemon
  5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2012-12-25  7:44 UTC (permalink / raw)
  To: ecos-patches

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001716

Charles Chiou <charleschiou@mips.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1998|assignment?(charleschiou@mi |
               Flag|ps.com)                     |
   Attachment #1998|0                           |1
        is obsolete|                            |

--- Comment #5 from Charles Chiou <charleschiou@mips.com> 2012-12-25 07:44:03 GMT ---
Created an attachment (id=2008)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=2008)
Attempt-2-20121225

Here's a second attempt after cleaning up the previous patch:
   - Renaming of constants, variables, and functions
   - Copyright headers (request just sent to assign@gnu.org)
   - Removed uart_debug() and uart2_printf()
   - extra .ld files removed and replaced with #ifdef's

- In the file mlt_mips_malta_ram.ldi, the output address is pushed back so that
it can work with Yamon & Redboot bootloaders and not overlap.

- uart2_channel work-around/bug will be filed and tracked.

Thank you

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1001716] MIPS malta + sead3 update
  2012-12-13  8:06 [Bug 1001716] New: MIPS malta + sead3 update bugzilla-daemon
                   ` (4 preceding siblings ...)
  2012-12-25  7:44 ` bugzilla-daemon
@ 2013-06-03 13:43 ` bugzilla-daemon
  5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2013-06-03 13:43 UTC (permalink / raw)
  To: ecos-patches

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001716

--- Comment #6 from John Dallaway <john@dallaway.org.uk> ---
Charles

You wrote:

> - Retain compatibility with QEMU's malta emulator
> - Verified to still work with mipsisa32-elf-gcc toolchain (eCosCentric GNU
> tools 4.3.2-sw)

I've been experimenting with your latest patch (Attempt-2-20121225) using the
above mipsisa32-elf toolchain and Qemu 1.5.0 (qemu-system-mipsel). I am using
target "malta_mips32_4kc" with the "default" template, importing
mipsisa32-elf-malta_qemu.ecm and then setting CYG_HAL_STARTUP == "ROM".

I can run simple eCos tests such as the bin_sem0 kernel test and see the test
output in the console, but most tests are hanging when the scheduler starts.

Can you let me know which version of Qemu you are using and how you configured
eCos for correct operation with mipsisa32-elf tools and Qemu?

Many thanks

John Dallaway

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2013-06-03 13:43 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-13  8:06 [Bug 1001716] New: MIPS malta + sead3 update bugzilla-daemon
2012-12-13 16:06 ` [Bug 1001716] " bugzilla-daemon
2012-12-13 16:14 ` bugzilla-daemon
2012-12-13 16:14 ` bugzilla-daemon
2012-12-13 17:15 ` bugzilla-daemon
2012-12-25  7:44 ` bugzilla-daemon
2013-06-03 13:43 ` bugzilla-daemon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).