From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31437 invoked by alias); 1 Jan 2013 21:22:25 -0000 Received: (qmail 31426 invoked by uid 22791); 1 Jan 2013 21:22:23 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Jan 2013 21:22:14 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 454F7468000E for ; Tue, 1 Jan 2013 21:22:13 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F2ecBWF75Mvd; Tue, 1 Jan 2013 21:22:12 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001219] Ethernet driver for STM32 connectivity line with port on MMstm32f107 board. X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: jerzdy@gmail.com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: ilijak@siva.com.mk X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Tue, 01 Jan 2013 21:22:00 -0000 Message-Id: <20130101212212.506794680001@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2013-01/txt/msg00004.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001219 --- Comment #50 from Jerzy Dyrda 2013-01-01 21:22:11 GMT --- Hello Ilija, (In reply to comment #45) > (In reply to comment #44) > > [snip] > > > > > Should I correct something or regenerate patch split into parts or > > patch in current state is acceptable? > > In addition to points 1..3 mentioned in comment 43: > > 4. Check naming of CDLs. For instance CYGNUM_DEVS_ETH_CORTEXM_STM32_INTF is not > numerical. Likewise CYGNUM_DEVS_ETH_CORTEXM_STM32_REMAP_PINS and some others. > You shall find CDL naming convention at > http://ecos.sourceware.org/docs-latest/cdl-guide/language.naming.html. > > 5. There are some lines longer than 78 char. Not too much longer (couple of > char is not a problem, but check them. > > 6. Clean up trailing spaces. > > 7. Update the copyright banners (now is 2012 and soon 2013). > 8. Likewise ChangeLog(s). Done. According to point 3. I put MCO setting into board dependent part. IMHO driver has to be generic and MCO configuration like source of clock and divider is up to board dependent set up. Best regards, jerzy -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.