From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11470 invoked by alias); 15 Dec 2008 09:31:32 -0000 Received: (qmail 11454 invoked by uid 22791); 15 Dec 2008 09:31:32 -0000 X-Spam-Level: * X-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_20,MSGID_FROM_MTA_HEADER,UNPARSEABLE_RELAY X-Spam-Check-By: sourceware.org Received: from mtaout01-winn.ispmail.ntl.com (HELO mtaout01-winn.ispmail.ntl.com) (81.103.221.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Dec 2008 09:30:44 +0000 Received: from aamtaout03-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20081215093033.JYTX1869.mtaout01-winn.ispmail.ntl.com@aamtaout03-winn.ispmail.ntl.com>; Mon, 15 Dec 2008 09:30:33 +0000 Received: from cog.dallaway.org.uk ([213.106.92.119]) by aamtaout03-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20081215093033.VXEV2093.aamtaout03-winn.ispmail.ntl.com@cog.dallaway.org.uk>; Mon, 15 Dec 2008 09:30:33 +0000 Received: from cog.dallaway.org.uk (cog.dallaway.org.uk [127.0.0.1]) by cog.dallaway.org.uk (8.13.8/8.13.8) with ESMTP id mBF9UV71020211; Mon, 15 Dec 2008 09:30:31 GMT Received: (from apache@localhost) by cog.dallaway.org.uk (8.13.8/8.13.8/Submit) id mBF9UU8v020210; Mon, 15 Dec 2008 09:30:30 GMT X-Authentication-Warning: cog.dallaway.org.uk: apache set sender to john@dallaway.org.uk using -f To: Spencer Oliver Subject: Re: configtool output save patch MIME-Version: 1.0 Date: Mon, 15 Dec 2008 09:31:00 -0000 From: John Dallaway Cc: ecos-patches@ecos.sourceware.org Message-ID: <32244d3f27dfe23a0574af638a7b937e@localhost> X-Sender: john@dallaway.org.uk Received: from 87-127-20-50.static-adsl.entanet.co.uk [87.127.20.50] with HTTP/1.1 (POST); Mon, 15 Dec 2008 09:30:30 +0000 User-Agent: RoundCube Webmail/0.2-beta Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Cloudmark-Analysis: v=1.0 c=1 a=B3H3McAPAAAA:8 a=Qyws5QzZdWO6DELdrhoA:9 a=uQA4BjEb1OOjzXsP6z_ovIYJMTEA:4 a=3SmO1NJXDBsA:10 Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2008-12/txt/msg00032.txt.bz2 Hi Spen Spencer Oliver wrote: > Attached is a minor configtool patch that fixes the output window save > function - currently disabled and does nothing. Thank you for the patch. Could you adapt your patch to call ecOutputWindow::OnSave() from ecMainFrame::OnSaveOutput() and avoid the code duplication? John Dallawayhttps://gw.dallaway.org.uk/roundcubemail/?_task=mail&_action=compose#