Re: FATFS bug

Re: FATFS bug

[Andrew Lunn]

On Tue, May 13, 2008 at 02:02:58PM +0200, Savin Zlobec wrote:
> Hi Andrew,
> 
> I've only recently read your mail on ecos-devel about fatfs '.' and '..' bug.
> Please find attached the fix.

Hi Savin

Thanks for the fix. I have committed it.

       Andrew

Re: FATFS bug

[Jonathan Larmour]

Andrew Lunn wrote:
> On Tue, May 13, 2008 at 02:02:58PM +0200, Savin Zlobec wrote:
>> I've only recently read your mail on ecos-devel about fatfs '.' and '..' bug.
>> Please find attached the fix.
> 
> Thanks for the fix. I have committed it.

[Patch in https://bugzilla.ecoscentric.com/show_bug.cgi?id=1000539 ]

Hi Savin,

I was looking at this patch. There's an aspect I'm unsure about. I admit I
haven't found any reason why it would go wrong (although that took a lot
head scratching!), but it seems to be a bit odd for a node for "." to be
added to the node cache where the parent cluster is actually that of a
subdirectory. Is this definitely the intended solution? I'm just worried
about unintended side-effects, given that you can then have multiple nodes
pointing to the same directory entry from different directions, so to speak.

Jifl
-- 
eCosCentric Limited      http://www.eCosCentric.com/     The eCos experts
Barnwell House, Barnwell Drive, Cambridge, UK.       Tel: +44 1223 245571
Registered in England and Wales: Reg No 4422071.
------["Si fractum non sit, noli id reficere"]------       Opinions==mine

Re: FATFS bug

[Savin Zlobec]

On Fri, Jan 9, 2009 at 4:58 PM, Jonathan Larmour <jifl@ecoscentric.com> wrote:
> Hi Savin,
>
> I was looking at this patch. There's an aspect I'm unsure about. I admit I
> haven't found any reason why it would go wrong (although that took a lot
> head scratching!), but it seems to be a bit odd for a node for "." to be
> added to the node cache where the parent cluster is actually that of a
> subdirectory. Is this definitely the intended solution? I'm just worried
> about unintended side-effects, given that you can then have multiple nodes
> pointing to the same directory entry from different directions, so to speak.

Hi Jifl,

It should be ok, but I'll recheck the patch to be sure.

Regards,
Savin