From: Michael Jones <mjones@linear.com>
To: "Lambrecht Jürgen" <J.Lambrecht@TELEVIC.com>
Cc: "ecos-patches@ecos.sourceware.org" <ecos-patches@ecos.sourceware.org>
Subject: Re: [PATCH] The DHCPREQUEST message should contain the same 'xid' as the DHCPOFFER message
Date: Wed, 12 Feb 2014 14:32:00 -0000 [thread overview]
Message-ID: <45BF36F1-2D74-464D-AAC6-D69F5D7D663B@linear.com> (raw)
In-Reply-To: <52FB723E.2080900@televic.com>
Jurgen,
I typically put these in bugzilla with an explanation. That is where people look for patches before they are part of the source tree. As far as I can tell, it is the only way patches become part of the code base.
Mike
On Feb 12, 2014, at 6:08 AM, Lambrecht Jürgen <J.Lambrecht@TELEVIC.com> wrote:
> Hi,
>
> I found a bug and fixed it, so I don't know if I need to use bugzilla
> for that?
> In attach the patch.
>
> file: net/common/current/src/dhcp_prot.c
>
> According to RFC 2131 (http://www.faqs.org/rfcs/rfc2131.html): "The
> DHCPREQUEST message contains the same 'xid' as the DHCPOFFER message."
> So in a DHCP DORA cycle (Discover-Offer-Request-Acknowledge) the same
> transaction ID should be used ('xid' in C code).
> We never had problems with that, but now we have a strict customer..
>
> Kind regards,
> Jürgen
>
> --
> Jürgen Lambrecht
> R&D Associate
> Mobile: +32 499 644 531
> Tel: +32 (0)51 303045 Fax: +32 (0)51 310670
> http://www.televic-rail.com
> Televic Rail NV - Leo Bekaertlaan 1 - 8870 Izegem - Belgium
> Company number 0825.539.581 - RPR Kortrijk
>
> <dhcp_prot.patch>
next prev parent reply other threads:[~2014-02-12 14:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 13:08 Lambrecht Jürgen
2014-02-12 14:32 ` Michael Jones [this message]
2014-02-15 0:03 ` "Ilija Kocho [Илија Кочо]"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45BF36F1-2D74-464D-AAC6-D69F5D7D663B@linear.com \
--to=mjones@linear.com \
--cc=J.Lambrecht@TELEVIC.com \
--cc=ecos-patches@ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).