From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5302 invoked by alias); 12 Feb 2014 14:32:25 -0000 Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org Received: (qmail 5291 invoked by uid 89); 12 Feb 2014 14:32:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_JMF_BR autolearn=no version=3.3.2 X-HELO: p02c11o144.mxlogic.net Received: from p02c11o144.mxlogic.net (HELO p02c11o144.mxlogic.net) (208.65.144.77) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 12 Feb 2014 14:32:22 +0000 Received: from unknown [12.218.215.72] (EHLO smtpauth1.linear.com) by p02c11o144.mxlogic.net(mxl_mta-7.2.4-1) with ESMTP id 4f58bf25.0.147704.00-286.297665.p02c11o144.mxlogic.net (envelope-from ); Wed, 12 Feb 2014 07:32:22 -0700 (MST) X-MXL-Hash: 52fb85f67433a6c0-6e5985ded34aba1253742ad132a624c840ea3fff Received: from [10.186.3.220] (unknown [10.186.3.220]) by smtpauth1.linear.com (Postfix) with ESMTPSA id 611F5740A1; Wed, 12 Feb 2014 06:32:18 -0800 (PST) Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: [PATCH] The DHCPREQUEST message should contain the same 'xid' as the DHCPOFFER message From: Michael Jones In-Reply-To: <52FB723E.2080900@televic.com> Date: Wed, 12 Feb 2014 14:32:00 -0000 Cc: "ecos-patches@ecos.sourceware.org" Content-Transfer-Encoding: quoted-printable Message-Id: <45BF36F1-2D74-464D-AAC6-D69F5D7D663B@linear.com> References: <52FB723E.2080900@televic.com> To: =?iso-8859-1?Q?Lambrecht_J=FCrgen?= X-AnalysisOut: [v=2.0 cv=Z7hb6gtA c=1 sm=1 a=glloKNylpeYNumXQcclYyA==:17 a] X-AnalysisOut: [=wy2N5vTbihEA:10 a=D2_GN2MmYMYA:10 a=BLceEmwcHowA:10 a=8nJ] X-AnalysisOut: [EP1OIZ-IA:10 a=MqDINYqSAAAA:8 a=8FX7uyy5FUsA:10 a=prgfXTrU] X-AnalysisOut: [AAAA:8 a=3hlIFYt5AAAA:8 a=bpHGPruPAAAA:8 a=0sJJ8kAL8DaAJqf] X-AnalysisOut: [JZZYA:9 a=wPNLvfGTeEIA:10 a=-SEWtxm_OEgA:10 a=ntesgRjRzHUA] X-AnalysisOut: [:10] X-Spam: [F=0.5000000000; CM=0.500; MH=0.500(2014021209); S=0.200(2010122901)] X-MAIL-FROM: X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00003.txt.bz2 Jurgen, I typically put these in bugzilla with an explanation. That is where people= look for patches before they are part of the source tree. As far as I can = tell, it is the only way patches become part of the code base. Mike On Feb 12, 2014, at 6:08 AM, Lambrecht J=FCrgen w= rote: > Hi, >=20 > I found a bug and fixed it, so I don't know if I need to use bugzilla=20 > for that? > In attach the patch. >=20 > file: net/common/current/src/dhcp_prot.c >=20 > According to RFC 2131 (http://www.faqs.org/rfcs/rfc2131.html): "The=20 > DHCPREQUEST message contains the same 'xid' as the DHCPOFFER message." > So in a DHCP DORA cycle (Discover-Offer-Request-Acknowledge) the same=20 > transaction ID should be used ('xid' in C code). > We never had problems with that, but now we have a strict customer.. >=20 > Kind regards, > J=FCrgen >=20 > --=20 > J=FCrgen Lambrecht > R&D Associate > Mobile: +32 499 644 531 > Tel: +32 (0)51 303045 Fax: +32 (0)51 310670 > http://www.televic-rail.com > Televic Rail NV - Leo Bekaertlaan 1 - 8870 Izegem - Belgium > Company number 0825.539.581 - RPR Kortrijk >=20 >