From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17575 invoked by alias); 17 Aug 2007 07:44:06 -0000 Received: (qmail 17161 invoked by uid 22791); 17 Aug 2007 07:44:03 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO,SPF_HELO_PASS,UPPERCASE_25_50 X-Spam-Check-By: sourceware.org Received: from moutng.kundenserver.de (HELO moutng.kundenserver.de) (212.227.126.179) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 17 Aug 2007 07:43:58 +0000 Received: from [87.123.99.110] (helo=intranator.net.lan) by mrelayeu.kundenserver.de (node=mrelayeu4) with ESMTP (Nemesis), id 0ML21M-1ILwUr2mY3-00085J; Fri, 17 Aug 2007 09:43:55 +0200 Received: from localhost (intranator.net.lan [127.0.0.1]) by localhost (Postfix) with ESMTP id 69A40ED; Fri, 17 Aug 2007 09:43:52 +0200 (CEST) Received: from [192.168.101.150] (kindler-mobil.net.lan [192.168.101.150]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by intranator.net.lan (Postfix) with ESMTP id 68626E3; Fri, 17 Aug 2007 09:43:50 +0200 (CEST) Message-ID: <46C55157.6010905@cetoni.de> Date: Fri, 17 Aug 2007 07:44:00 -0000 From: cetoni GmbH - Uwe Kindler Organization: cetoni GmbH User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: ecos-patches@sourceware.org CC: rosenfeld@grumpf.hope-2000.org Subject: Re: LPC2xxx CAN bugfixes Content-Type: multipart/mixed; boundary="------------050903010808080103050309" X-Virus-Scanned: by Intranator (www.intranator.com) with AMaViS and F-Secure AntiVirus (fsavdb 2007-08-17_01) X-Spam-Level: 982 X-Provags-ID: V01U2FsdGVkX1+poO8MQmb+MriupohC+m2vVlBp/ldwtZ7nHgi eE9E4/5ZltLawZTw0BxuInqeNWRoeQ224M6SaOUuHm8U+BA++a iXeB1oPgCxsBJzYfE4wefFthOKJrjrq X-Virus-Checked: Checked by ClamAV on sourceware.org Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2007-08/txt/msg00022.txt.bz2 This is a multi-part message in MIME format. --------------050903010808080103050309 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Content-length: 287 Hello, the following LPC2xxx CAN patch fixes the issues mentioned by Hans Rosenfeld. Dipl. Inf. (FH) Uwe Kindler Software Engineering -- cetoni GmbH Am Wiesenring 6 D-07554 Korbussen Tel.: +49 (0) 36602 338 28 Fax: +49 (0) 36602 338 11 uwe.kindler@cetoni.de http://www.cetoni.de --------------050903010808080103050309 Content-Type: text/plain; name="can_lpc2xxx.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="can_lpc2xxx.patch" Content-length: 10728 diff -ruN ecos_web_cvs/ecos/packages/devs/can/arm/lpc2xxx/current/ChangeLog ecos/ecos/packages/devs/can/arm/lpc2xxx/current/ChangeLog --- ecos_web_cvs/ecos/packages/devs/can/arm/lpc2xxx/current/ChangeLog 2007-08-02 10:48:00.000000000 +0200 +++ ecos/ecos/packages/devs/can/arm/lpc2xxx/current/ChangeLog 2007-08-17 08:12:30.000000000 +0200 @@ -1,3 +1,13 @@ +2007-08-17 Uwe Kindler + + * include/can_lpc2xxx_baudrates.h: Removed all prefixed zeros from + baudrate table entries (they aren't intended to be interpreted as + octal) + + * tests/can_baudrates.c + tests/can_busload.c + tests/can_rx_tx.c: removed #include pkgconf/devs_can_loop.h + 2007-08-02 Alexey Shusharin * src/can_lpc2xxx.c: Added acknowledging call in rx interrupt diff -ruN ecos_web_cvs/ecos/packages/devs/can/arm/lpc2xxx/current/include/can_lpc2xxx_baudrates.h ecos/ecos/packages/devs/can/arm/lpc2xxx/current/include/can_lpc2xxx_baudrates.h --- ecos_web_cvs/ecos/packages/devs/can/arm/lpc2xxx/current/include/can_lpc2xxx_baudrates.h 2007-07-31 09:53:36.000000000 +0200 +++ ecos/ecos/packages/devs/can/arm/lpc2xxx/current/include/can_lpc2xxx_baudrates.h 2007-08-17 07:57:01.000000000 +0200 @@ -75,16 +75,16 @@ // static const cyg_uint32 lpc2xxx_br_tbl[] = { - CAN_BR_TBL_ENTRY(300, 15, 02, 0, 1), // 10 kbaud - CAN_BR_TBL_ENTRY(150, 15, 02, 0, 1), // 20 kbaud - CAN_BR_TBL_ENTRY(59, 15, 02, 0, 1), // 50 kbaud - CAN_BR_TBL_ENTRY(39, 11, 01, 0, 1), // 100 kbaud - CAN_BR_TBL_ENTRY(29, 12, 01, 0, 1), // 125 kbaud - CAN_BR_TBL_ENTRY(14, 12, 01, 0, 1), // 250 kbaud - CAN_BR_TBL_ENTRY(07, 11, 01, 0, 0), // 500 kbaud - CAN_BR_TBL_ENTRY(04, 11, 01, 0, 0), // 800 kbaud - CAN_BR_TBL_ENTRY(03, 11, 01, 0, 0), // 1000 kbaud - CAN_BR_TBL_ENTRY(00, 00, 00, 0, 0), // Autobaud - not supported + CAN_BR_TBL_ENTRY(300, 15, 2, 0, 1), // 10 kbaud + CAN_BR_TBL_ENTRY(150, 15, 2, 0, 1), // 20 kbaud + CAN_BR_TBL_ENTRY(59, 15, 2, 0, 1), // 50 kbaud + CAN_BR_TBL_ENTRY(39, 11, 1, 0, 1), // 100 kbaud + CAN_BR_TBL_ENTRY(29, 12, 1, 0, 1), // 125 kbaud + CAN_BR_TBL_ENTRY(14, 12, 1, 0, 1), // 250 kbaud + CAN_BR_TBL_ENTRY( 7, 11, 1, 0, 0), // 500 kbaud + CAN_BR_TBL_ENTRY( 4, 11, 1, 0, 0), // 800 kbaud + CAN_BR_TBL_ENTRY( 3, 11, 1, 0, 0), // 1000 kbaud + CAN_BR_TBL_ENTRY( 0, 0, 0, 0, 0), // Autobaud - not supported }; #define HAL_LPC2XXX_BAUD_TBL_DEFINED 1 #endif // CYGNUM_CAN_LPC2XXX_VPB_CLK == 60000000 @@ -95,16 +95,16 @@ // static const cyg_uint32 lpc2xxx_br_tbl[] = { - CAN_BR_TBL_ENTRY(00, 00, 00, 0, 0), // 10 kbaud - not supported - CAN_BR_TBL_ENTRY(00, 00, 00, 0, 0), // 20 kbaud - not supported - CAN_BR_TBL_ENTRY(59, 15, 02, 0, 1), // 50 kbaud - CAN_BR_TBL_ENTRY(39, 11, 01, 0, 1), // 100 kbaud - CAN_BR_TBL_ENTRY(29, 12, 01, 0, 1), // 125 kbaud - CAN_BR_TBL_ENTRY(14, 12, 01, 0, 1), // 250 kbaud - CAN_BR_TBL_ENTRY(07, 11, 01, 0, 0), // 500 kbaud - CAN_BR_TBL_ENTRY(04, 11, 01, 0, 0), // 800 kbaud - CAN_BR_TBL_ENTRY(03, 11, 01, 0, 0), // 1000 kbaud - CAN_BR_TBL_ENTRY(00, 00, 00, 0, 0), // Autobaud - not supported + CAN_BR_TBL_ENTRY( 0, 0, 0, 0, 0), // 10 kbaud - not supported + CAN_BR_TBL_ENTRY( 0, 0, 0, 0, 0), // 20 kbaud - not supported + CAN_BR_TBL_ENTRY(59, 15, 2, 0, 1), // 50 kbaud + CAN_BR_TBL_ENTRY(39, 11, 1, 0, 1), // 100 kbaud + CAN_BR_TBL_ENTRY(29, 12, 1, 0, 1), // 125 kbaud + CAN_BR_TBL_ENTRY(14, 12, 1, 0, 1), // 250 kbaud + CAN_BR_TBL_ENTRY( 7, 11, 1, 0, 0), // 500 kbaud + CAN_BR_TBL_ENTRY( 4, 11, 1, 0, 0), // 800 kbaud + CAN_BR_TBL_ENTRY( 3, 11, 1, 0, 0), // 1000 kbaud + CAN_BR_TBL_ENTRY( 0, 0, 0, 0, 0), // Autobaud - not supported }; #define HAL_LPC2XXX_BAUD_TBL_DEFINED 1 #endif // CYGNUM_CAN_LPC2XXX_VPB_CLK == 30000000 @@ -115,16 +115,16 @@ // static const cyg_uint32 lpc2xxx_br_tbl[] = { - CAN_BR_TBL_ENTRY(59, 15, 07, 0, 1), // 10 kbaud - CAN_BR_TBL_ENTRY(49, 11, 01, 0, 1), // 20 kbaud - CAN_BR_TBL_ENTRY(19, 11, 01, 0, 1), // 50 kbaud - CAN_BR_TBL_ENTRY(09, 11, 01, 0, 1), // 100 kbaud - CAN_BR_TBL_ENTRY(07, 11, 01, 0, 1), // 125 kbaud - CAN_BR_TBL_ENTRY(03, 11, 01, 0, 1), // 250 kbaud - CAN_BR_TBL_ENTRY(01, 11, 01, 0, 0), // 500 kbaud - CAN_BR_TBL_ENTRY(00, 00, 00, 0, 0), // 800 kbaud - not supported - CAN_BR_TBL_ENTRY(00, 11, 01, 0, 0), // 1000 kbaud - CAN_BR_TBL_ENTRY(00, 00, 00, 0, 0), // Autobaud - not supported + CAN_BR_TBL_ENTRY(59, 15, 7, 0, 1), // 10 kbaud + CAN_BR_TBL_ENTRY(49, 11, 1, 0, 1), // 20 kbaud + CAN_BR_TBL_ENTRY(19, 11, 1, 0, 1), // 50 kbaud + CAN_BR_TBL_ENTRY( 9, 11, 1, 0, 1), // 100 kbaud + CAN_BR_TBL_ENTRY( 7, 11, 1, 0, 1), // 125 kbaud + CAN_BR_TBL_ENTRY( 3, 11, 1, 0, 1), // 250 kbaud + CAN_BR_TBL_ENTRY( 1, 11, 1, 0, 0), // 500 kbaud + CAN_BR_TBL_ENTRY( 0, 0, 0, 0, 0), // 800 kbaud - not supported + CAN_BR_TBL_ENTRY( 0, 11, 1, 0, 0), // 1000 kbaud + CAN_BR_TBL_ENTRY( 0, 0, 0, 0, 0), // Autobaud - not supported }; #define HAL_LPC2XXX_BAUD_TBL_DEFINED 1 #endif // CYGNUM_CAN_LPC2XXX_VPB_CLK == 15000000 @@ -135,16 +135,16 @@ // static const cyg_uint32 lpc2xxx_br_tbl[] = { - CAN_BR_TBL_ENTRY(00, 00, 00, 0, 0), // 10 kbaud - not supported - CAN_BR_TBL_ENTRY(00, 00, 00, 0, 0), // 20 kbaud - not supported - CAN_BR_TBL_ENTRY(59, 12, 01, 0, 1), // 50 kbaud - CAN_BR_TBL_ENTRY(29, 12, 01, 0, 1), // 100 kbaud - CAN_BR_TBL_ENTRY(23, 12, 01, 0, 1), // 125 kbaud - CAN_BR_TBL_ENTRY(11, 12, 01, 0, 1), // 250 kbaud - CAN_BR_TBL_ENTRY(05, 12, 01, 0, 0), // 500 kbaud - CAN_BR_TBL_ENTRY(03, 11, 01, 0, 0), // 800 kbaud - CAN_BR_TBL_ENTRY(02, 12, 01, 0, 0), // 1000 kbaud - CAN_BR_TBL_ENTRY(00, 00, 00, 0, 0), // Autobaud - not supported + CAN_BR_TBL_ENTRY( 0, 0, 0, 0, 0), // 10 kbaud - not supported + CAN_BR_TBL_ENTRY( 0, 0, 0, 0, 0), // 20 kbaud - not supported + CAN_BR_TBL_ENTRY(59, 12, 1, 0, 1), // 50 kbaud + CAN_BR_TBL_ENTRY(29, 12, 1, 0, 1), // 100 kbaud + CAN_BR_TBL_ENTRY(23, 12, 1, 0, 1), // 125 kbaud + CAN_BR_TBL_ENTRY(11, 12, 1, 0, 1), // 250 kbaud + CAN_BR_TBL_ENTRY( 5, 12, 1, 0, 0), // 500 kbaud + CAN_BR_TBL_ENTRY( 3, 11, 1, 0, 0), // 800 kbaud + CAN_BR_TBL_ENTRY( 2, 12, 1, 0, 0), // 1000 kbaud + CAN_BR_TBL_ENTRY( 0, 0, 0, 0, 0), // Autobaud - not supported }; #define HAL_LPC2XXX_BAUD_TBL_DEFINED 1 #endif // CYGNUM_CAN_LPC2XXX_VPB_CLK == 48000000 @@ -155,16 +155,16 @@ // static const cyg_uint32 lpc2xxx_br_tbl[] = { - CAN_BR_TBL_ENTRY(00, 00, 00, 0, 0), // 10 kbaud - not supported - CAN_BR_TBL_ENTRY(59, 15, 02, 0, 1), // 20 kbaud - CAN_BR_TBL_ENTRY(29, 12, 01, 0, 1), // 50 kbaud - CAN_BR_TBL_ENTRY(14, 12, 01, 0, 1), // 100 kbaud - CAN_BR_TBL_ENTRY(11, 12, 01, 0, 1), // 125 kbaud - CAN_BR_TBL_ENTRY(05, 12, 01, 0, 1), // 250 kbaud - CAN_BR_TBL_ENTRY(02, 12, 01, 0, 0), // 500 kbaud - CAN_BR_TBL_ENTRY(01, 11, 01, 0, 0), // 800 kbaud - CAN_BR_TBL_ENTRY(01, 05, 00, 0, 0), // 1000 kbaud - CAN_BR_TBL_ENTRY(00, 00, 00, 0, 0), // Autobaud - not supported + CAN_BR_TBL_ENTRY( 0, 0, 0, 0, 0), // 10 kbaud - not supported + CAN_BR_TBL_ENTRY(59, 15, 2, 0, 1), // 20 kbaud + CAN_BR_TBL_ENTRY(29, 12, 1, 0, 1), // 50 kbaud + CAN_BR_TBL_ENTRY(14, 12, 1, 0, 1), // 100 kbaud + CAN_BR_TBL_ENTRY(11, 12, 1, 0, 1), // 125 kbaud + CAN_BR_TBL_ENTRY( 5, 12, 1, 0, 1), // 250 kbaud + CAN_BR_TBL_ENTRY( 2, 12, 1, 0, 0), // 500 kbaud + CAN_BR_TBL_ENTRY( 1, 11, 1, 0, 0), // 800 kbaud + CAN_BR_TBL_ENTRY( 1, 5, 0, 0, 0), // 1000 kbaud + CAN_BR_TBL_ENTRY( 0, 0, 0, 0, 0), // Autobaud - not supported }; #define HAL_LPC2XXX_BAUD_TBL_DEFINED 1 #endif // CYGNUM_CAN_LPC2XXX_VPB_CLK == 24000000 @@ -175,16 +175,16 @@ // static const cyg_uint32 lpc2xxx_br_tbl[] = { - CAN_BR_TBL_ENTRY(59, 15, 02, 0, 1), // 10 kbaud - not supported - CAN_BR_TBL_ENTRY(39, 11, 01, 0, 1), // 20 kbaud - CAN_BR_TBL_ENTRY(14, 12, 01, 0, 1), // 50 kbaud - CAN_BR_TBL_ENTRY(07, 11, 01, 0, 1), // 100 kbaud - CAN_BR_TBL_ENTRY(05, 12, 01, 0, 1), // 125 kbaud - CAN_BR_TBL_ENTRY(02, 12, 01, 0, 1), // 250 kbaud - CAN_BR_TBL_ENTRY(02, 05, 00, 0, 0), // 500 kbaud - CAN_BR_TBL_ENTRY(00, 11, 01, 0, 0), // 800 kbaud - CAN_BR_TBL_ENTRY(00, 09, 00, 0, 0), // 1000 kbaud - CAN_BR_TBL_ENTRY(00, 00, 00, 0, 0), // Autobaud - not supported + CAN_BR_TBL_ENTRY(59, 15, 2, 0, 1), // 10 kbaud - not supported + CAN_BR_TBL_ENTRY(39, 11, 1, 0, 1), // 20 kbaud + CAN_BR_TBL_ENTRY(14, 12, 1, 0, 1), // 50 kbaud + CAN_BR_TBL_ENTRY( 7, 11, 1, 0, 1), // 100 kbaud + CAN_BR_TBL_ENTRY( 5, 12, 1, 0, 1), // 125 kbaud + CAN_BR_TBL_ENTRY( 2, 12, 1, 0, 1), // 250 kbaud + CAN_BR_TBL_ENTRY( 2, 05, 0, 0, 0), // 500 kbaud + CAN_BR_TBL_ENTRY( 0, 11, 1, 0, 0), // 800 kbaud + CAN_BR_TBL_ENTRY( 0, 9, 0, 0, 0), // 1000 kbaud + CAN_BR_TBL_ENTRY( 0, 0, 0, 0, 0), // Autobaud - not supported }; #define HAL_LPC2XXX_BAUD_TBL_DEFINED 1 #endif // CYGNUM_CAN_LPC2XXX_VPB_CLK == 12000000 diff -ruN ecos_web_cvs/ecos/packages/devs/can/arm/lpc2xxx/current/tests/can_baudrates.c ecos/ecos/packages/devs/can/arm/lpc2xxx/current/tests/can_baudrates.c --- ecos_web_cvs/ecos/packages/devs/can/arm/lpc2xxx/current/tests/can_baudrates.c 2007-07-03 16:49:05.000000000 +0200 +++ ecos/ecos/packages/devs/can/arm/lpc2xxx/current/tests/can_baudrates.c 2007-08-17 07:57:22.000000000 +0200 @@ -62,7 +62,6 @@ #include #include #include -#include // Package option requirements diff -ruN ecos_web_cvs/ecos/packages/devs/can/arm/lpc2xxx/current/tests/can_busload.c ecos/ecos/packages/devs/can/arm/lpc2xxx/current/tests/can_busload.c --- ecos_web_cvs/ecos/packages/devs/can/arm/lpc2xxx/current/tests/can_busload.c 2007-07-03 16:49:05.000000000 +0200 +++ ecos/ecos/packages/devs/can/arm/lpc2xxx/current/tests/can_busload.c 2007-08-17 07:57:31.000000000 +0200 @@ -62,7 +62,6 @@ #include #include #include -#include // Package option requirements diff -ruN ecos_web_cvs/ecos/packages/devs/can/arm/lpc2xxx/current/tests/can_rx_tx.c ecos/ecos/packages/devs/can/arm/lpc2xxx/current/tests/can_rx_tx.c --- ecos_web_cvs/ecos/packages/devs/can/arm/lpc2xxx/current/tests/can_rx_tx.c 2007-07-03 16:49:05.000000000 +0200 +++ ecos/ecos/packages/devs/can/arm/lpc2xxx/current/tests/can_rx_tx.c 2007-08-17 07:57:45.000000000 +0200 @@ -62,7 +62,6 @@ #include #include #include -#include // Package option requirements --------------050903010808080103050309--