From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9656 invoked by alias); 21 Aug 2007 06:12:50 -0000 Received: (qmail 9296 invoked by uid 22791); 21 Aug 2007 06:12:48 -0000 X-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from moutng.kundenserver.de (HELO moutng.kundenserver.de) (212.227.126.183) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 21 Aug 2007 06:12:43 +0000 Received: from i577B458C.versanet.de [87.123.69.140] (helo=intranator.net.lan) by mrelayeu.kundenserver.de (node=mrelayeu3) with ESMTP (Nemesis), id 0MKxQS-1INMyl45Ec-0008DF; Tue, 21 Aug 2007 08:12:40 +0200 Received: from localhost (intranator.net.lan [127.0.0.1]) by localhost (Postfix) with ESMTP id E2AB5EC; Tue, 21 Aug 2007 08:12:37 +0200 (CEST) Received: from [192.168.101.150] (kindler-mobil.net.lan [192.168.101.150]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by intranator.net.lan (Postfix) with ESMTP id CF441E3; Tue, 21 Aug 2007 08:12:35 +0200 (CEST) Message-ID: <46CA81F3.60109@cetoni.de> Date: Tue, 21 Aug 2007 06:12:00 -0000 From: cetoni GmbH - Uwe Kindler Organization: cetoni GmbH User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: ecos-patches@sourceware.org CC: Hans Rosenfeld Subject: Re: LPC2xxx patch for support of vectored interrupt controller Content-Type: text/plain; charset=ISO-8859-15; format=flowed X-Virus-Scanned: by Intranator (www.intranator.com) with AMaViS and F-Secure AntiVirus (fsavdb 2007-08-21_01) X-Spam-Level: 982 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V01U2FsdGVkX1/5PHgSmwA3yYy/Jpyb/dXInnWpzxrCfbKkBPG CHLIDLq0ELTMoy7GkgePhWq1KTDJsrfvCt1jW6YGEuj6nD3M21 REDegYVSILgTXDGOEXJ1HthkBXm/faM Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2007-08/txt/msg00036.txt.bz2 Hello Hans, ------> I think it would be better to change this assertion into a simple test, so that calling hal_interrupt_configure() with an un-configurable interrupt vector just does nothing. <----- I dont't agree with this change. If I configure a system and do a=20 mistake setting up interrupt priorities then my only chance and a very=20 good way to catch this error is this assertion. If you silently drop=20 this failure just to make a test case happy then you may pass the test=20 but you will run into trouble with your real application. Btw. the assertion I put into the code is wrong: CYG_ASSERT(vector <=3D CYGNUM_HAL_INTERRUPT_EINT3 && vector >=3D CYGNUM_HAL_INTERRUPT_EINT0 , "Invalid vector"); should be: CYG_ASSERT(vector <=3D CYGNUM_HAL_INTERRUPT_EINT3 || vector >=3D CYGNUM_HAL_INTERRUPT_EINT0 , "Invalid vector"); Hello Andrew, what do you think about the patch. Is it okay to remove=20 the assertion just to make test cases happy? Kind regards, Uwe Mit freundlichen Gr=FC=DFen, Dipl. Inf. (FH) Uwe Kindler Software Engineering -- cetoni GmbH Am Wiesenring 6 D-07554 Korbussen Tel.: +49 (0) 36602 338 28 Fax: +49 (0) 36602 338 11 uwe.kindler@cetoni.de www.cetoni.de