From: Jonathan Larmour <jifl@eCosCentric.com>
To: Grant Edwards <grante@visi.com>
Cc: ecos-patches@ecos.sourceware.org
Subject: Re: Fix for hal_endian.h SWAP16() macro
Date: Thu, 27 Sep 2007 15:32:00 -0000 [thread overview]
Message-ID: <46FBCD17.3030803@eCosCentric.com> (raw)
In-Reply-To: <20070927150905.GA25037@grante.dsl.visi.com>
Grant Edwards wrote:
> On Mon, Sep 24, 2007 at 11:57:01AM -0500, Grant Edwards wrote:
>
>> The SWAP16() macro is broken.
>>
>> unsigned u = SWAP16(0x1234);
>>
>> u will be 0x123412 instead of 0x3412.
>>
>> Here's a fix.
>>
>> I believe that the SWAP32() macro will also break in a similar
>> way on systems where "int" is larger than 32 bits, but I have
>> no way to test that conjecture.
Feel free to make a guess.
> OK, this time with a Changelog entry. I have a hard time
> remembering to edit the changelog since I use CVS to keep track
> of such thing.
Thanks, applied.
Jifl
--
eCosCentric Limited http://www.eCosCentric.com/ The eCos experts
Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571
Registered in England and Wales: Reg No 4422071.
>>>> Visit us on stand 810 at The Embedded Systems Show 2007, NEC <<<<
>>>> Oct 17-18 Birmingham, UK http://www.edaexhibitions.com/ess/ <<<<
------["The best things in life aren't things."]------ Opinions==mine
prev parent reply other threads:[~2007-09-27 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-24 16:57 Grant Edwards
2007-09-27 15:09 ` Grant Edwards
2007-09-27 15:32 ` Jonathan Larmour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FBCD17.3030803@eCosCentric.com \
--to=jifl@ecoscentric.com \
--cc=ecos-patches@ecos.sourceware.org \
--cc=grante@visi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).