From: Jonathan Larmour <jifl@eCosCentric.com>
To: Jay Foster <jay@systech.com>
Cc: 'Andrew Lunn' <andrew@lunn.ch>,
Rainer Arndt <Arndt-ADT@kieback-peter.de>,
ecos-patches@ecos.sourceware.org
Subject: Re: Incomplete baud rate mapping in termiostty.c
Date: Wed, 05 Mar 2008 16:06:00 -0000 [thread overview]
Message-ID: <47CEC4D7.1040200@eCosCentric.com> (raw)
In-Reply-To: <74C9525D67A5FF4791614FDB06593BB10429A475@mail.systech.com>
Jay Foster wrote:
> Should the setting of priv->init = true be dependent on the return value of
> real_termios_init()?
>
> res = real_termios_init();
> if (ENOERR == res)
> priv->init = true;
>
> Or maybe it doesn't matter.
Probably better to ignore the return value so the device can be retried on
subsequent calls - the only relevant failure mode is in retrieving the
config and maybe it was a transient error.
Jifl
--
eCosCentric Limited http://www.eCosCentric.com/ The eCos experts
Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571
Registered in England and Wales: Reg No 4422071.
------["Si fractum non sit, noli id reficere"]------ Opinions==mine
next prev parent reply other threads:[~2008-03-05 16:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 21:17 Jay Foster
2008-03-05 16:06 ` Jonathan Larmour [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-30 16:59 Rainer Arndt
2008-01-30 17:48 ` Andrew Lunn
2008-01-30 18:41 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CEC4D7.1040200@eCosCentric.com \
--to=jifl@ecoscentric.com \
--cc=Arndt-ADT@kieback-peter.de \
--cc=andrew@lunn.ch \
--cc=ecos-patches@ecos.sourceware.org \
--cc=jay@systech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).