From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21522 invoked by alias); 5 Mar 2008 16:06:17 -0000 Received: (qmail 21503 invoked by uid 22791); 5 Mar 2008 16:06:16 -0000 X-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from snape.ecoscentric.com (HELO snape.ecoscentric.com) (212.13.207.199) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Mar 2008 16:05:48 +0000 Received: from localhost (snape.ecoscentric.com [127.0.0.1]) by snape.ecoscentric.com (Postfix) with ESMTP id ACCD2DC8D6D; Wed, 5 Mar 2008 16:05:45 +0000 (GMT) X-Virus-Scanned: amavisd-new at ecoscentric.com Received: from snape.ecoscentric.com ([127.0.0.1]) by localhost (snape.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k66QMIcP7mXh; Wed, 5 Mar 2008 16:05:44 +0000 (GMT) Message-ID: <47CEC4D7.1040200@eCosCentric.com> Date: Wed, 05 Mar 2008 16:06:00 -0000 From: Jonathan Larmour User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Jay Foster CC: 'Andrew Lunn' , Rainer Arndt , ecos-patches@ecos.sourceware.org Subject: Re: Incomplete baud rate mapping in termiostty.c References: <74C9525D67A5FF4791614FDB06593BB10429A475@mail.systech.com> In-Reply-To: <74C9525D67A5FF4791614FDB06593BB10429A475@mail.systech.com> X-Enigmail-Version: 0.94.4.0 OpenPGP: id=A5FB74E6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2008-03/txt/msg00004.txt.bz2 Jay Foster wrote: > Should the setting of priv->init = true be dependent on the return value of > real_termios_init()? > > res = real_termios_init(); > if (ENOERR == res) > priv->init = true; > > Or maybe it doesn't matter. Probably better to ignore the return value so the device can be retried on subsequent calls - the only relevant failure mode is in retrieving the config and maybe it was a transient error. Jifl -- eCosCentric Limited http://www.eCosCentric.com/ The eCos experts Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571 Registered in England and Wales: Reg No 4422071. ------["Si fractum non sit, noli id reficere"]------ Opinions==mine