From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5982 invoked by alias); 31 Dec 2008 16:18:14 -0000 Received: (qmail 5949 invoked by uid 22791); 31 Dec 2008 16:18:12 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mtaout02-winn.ispmail.ntl.com (HELO mtaout02-winn.ispmail.ntl.com) (81.103.221.48) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Dec 2008 16:17:29 +0000 Received: from aamtaout02-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout02-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20081231161725.PLFC4080.mtaout02-winn.ispmail.ntl.com@aamtaout02-winn.ispmail.ntl.com>; Wed, 31 Dec 2008 16:17:25 +0000 Received: from cog.dallaway.org.uk ([213.106.92.119]) by aamtaout02-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20081231161725.RCHD21638.aamtaout02-winn.ispmail.ntl.com@cog.dallaway.org.uk>; Wed, 31 Dec 2008 16:17:25 +0000 Received: from cog.dallaway.org.uk (cog.dallaway.org.uk [127.0.0.1]) by cog.dallaway.org.uk (8.13.8/8.13.8) with ESMTP id mBVGHNUH019786; Wed, 31 Dec 2008 16:17:23 GMT Message-ID: <495B9B13.5030007@dallaway.org.uk> Date: Wed, 31 Dec 2008 16:18:00 -0000 From: John Dallaway User-Agent: Thunderbird 2.0.0.18 (X11/20081120) MIME-Version: 1.0 To: Spencer Oliver CC: ecos-patches@ecos.sourceware.org Subject: Re: configtool output save patch References: <32244d3f27dfe23a0574af638a7b937e@localhost> <49160.0849004046$1229427834@news.gmane.org> In-Reply-To: <49160.0849004046$1229427834@news.gmane.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2008-12/txt/msg00065.txt.bz2 Spencer Oliver wrote: >>> Attached is a minor configtool patch that fixes the output >>> window save function - currently disabled and does nothing. >> >> Thank you for the patch. Could you adapt your patch to call >> ecOutputWindow::OnSave() from ecMainFrame::OnSaveOutput() and >> avoid the code duplication? > > Is this a bit better? Thank you for the updated patch. Now checked in with minor changes and updated file dialog text. John Dallaway