From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6817 invoked by alias); 22 Feb 2010 12:51:42 -0000 Received: (qmail 6794 invoked by uid 22791); 22 Feb 2010 12:51:40 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from ffm.saftware.de (HELO ffm.saftware.de) (83.141.3.46) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Feb 2010 12:51:36 +0000 Received: from localhost (localhost [127.0.0.1]) by ffm.saftware.de (Postfix) with ESMTP id 4422EE6B24; Mon, 22 Feb 2010 13:51:33 +0100 (CET) Received: from ffm.saftware.de ([83.141.3.46]) by localhost (pinky.saftware.de [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1PrK3eBuYUGB; Mon, 22 Feb 2010 13:51:27 +0100 (CET) Message-ID: <4B827DCF.50702@saftware.de> Date: Mon, 22 Feb 2010 12:51:00 -0000 From: Andreas Oberritter User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Gary Thomas CC: ecos-patches@sources.redhat.com Subject: Re: [PATCH 0/3] misc fixes for eCos 3.0 References: <1266772191-28315-1-git-send-email-obi@saftware.de> <4B82707E.2090701@mlbassoc.com> In-Reply-To: <4B82707E.2090701@mlbassoc.com> OpenPGP: id=0C50A57A; url=http://www.saftware.de/obi.pub Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2010-02/txt/msg00016.txt.bz2 Gary Thomas wrote: > Not much use without some explanation of what they do. > Accepted practice is to explain each change, so it can be > properly understood and discussed. I thought that the reason for these changes were pretty obvious. I'll try to explain them now, though: [PATCH 1/3] usbs_at91: call vendor_control_fn on USB_DEVREQ_TYPE_VENDOR: For each type of USB control requests (USB_DEVREQ_TYPE_XXX), there is a callback function called xxx_control_fn(). For vendor requests, the wrong function was called. It looks like a copy and paste bug. The function class_control_fn() should only be called for USB_DEVREQ_TYPE_CLASS. [PATCH 2/3] usbseth: compile fix: move misplaced #endif: Compilation aborted, because HAL_DCACHE_LINE_SIZE was not defined. A look at the code revealed, that the following code does not make sense: #ifndef XXX x = expr; #else #endif x = expr using XXX; [PATCH 3/3] tcpip: compile fix: remove unneeded cast to long in TCPT_RANGESET: Compilation aborted using the toolchain supplied by the eCos installer (gcc 4.3.2), because of an invalid cast: error: "lvalue required as left operand of assignment" Therefore, TCPT_RANGESET was adjusted in two places to match the usage pattern of other users of this macro, which simply omit the cast. Regards, Andreas