From: Kirill Berezin <kyb@online.ru>
To: ecos-patches@ecos.sourceware.org
Subject: Correct redboot hang with uninitialized config.
Date: Fri, 23 Apr 2010 10:27:00 -0000 [thread overview]
Message-ID: <4BD175F9.8080808@online.ru> (raw)
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
Hello,
I suddenly came across possible hang or sigfault condition for redboot
with no configuration stored in flash.
The current version of dns module has a default initialization of dns
domain as a pointer to zero.
As a result redboot hangs on boot on mips32 platform. I attached a patch
with possible solution, I hope it will be helpful.
Kirill.
[-- Attachment #2: redboot_dns_init.diff --]
[-- Type: text/plain, Size: 660 bytes --]
Index: dns.c
===================================================================
RCS file: /cvs/ecos/ecos/packages/redboot/current/src/net/dns.c,v
retrieving revision 1.5
diff -c -r1.5 dns.c
*** dns.c 29 Jan 2009 17:50:04 -0000 1.5
--- dns.c 22 Apr 2010 12:09:32 -0000
***************
*** 76,82 ****
dns_domain,
ALWAYS_ENABLED, true,
CONFIG_STRING,
! 0
);
#endif
--- 76,82 ----
dns_domain,
ALWAYS_ENABLED, true,
CONFIG_STRING,
! ""
);
#endif
next reply other threads:[~2010-04-23 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 10:27 Kirill Berezin [this message]
2010-04-23 12:02 ` John Dallaway
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD175F9.8080808@online.ru \
--to=kyb@online.ru \
--cc=ecos-patches@ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).