* [PATCH] cygwin: define PATH_MAX for host tools build
@ 2010-05-04 12:27 Spencer Oliver
2010-05-12 13:09 ` Jonathan Larmour
0 siblings, 1 reply; 6+ messages in thread
From: Spencer Oliver @ 2010-05-04 12:27 UTC (permalink / raw)
To: ecos-patches
[-- Attachment #1: Type: text/plain, Size: 45 bytes --]
cygwin: define PATH_MAX for host tools build
[-- Attachment #2: ecos.hg_rev2950.patch --]
[-- Type: text/plain, Size: 643 bytes --]
# HG changeset patch
# User Spencer Oliver <spen@spen-soft.co.uk>
# Date 1272975669 -3600
# Node ID c0527a4c2b5e3f6fbe82ec4c3f7568e6caf17355
# Parent c88d9f19de1aa679335bbec8b609e824d1fbd015
cygwin: define PATH_MAX for host tools build
diff -r c88d9f19de1a -r c0527a4c2b5e host/tools/Utils/common/eCosStd.h
--- a/host/tools/Utils/common/eCosStd.h Tue May 04 13:19:54 2010 +0100
+++ b/host/tools/Utils/common/eCosStd.h Tue May 04 13:21:09 2010 +0100
@@ -52,6 +52,7 @@
#include <malloc.h> // malloc
#include <stdlib.h> // atoi
+ #include <limits.h> // PATH_MAX
#include <errno.h>
#define WOULDBLOCK WSAEWOULDBLOCK
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cygwin: define PATH_MAX for host tools build
2010-05-04 12:27 [PATCH] cygwin: define PATH_MAX for host tools build Spencer Oliver
@ 2010-05-12 13:09 ` Jonathan Larmour
2010-05-12 15:06 ` John Dallaway
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Larmour @ 2010-05-12 13:09 UTC (permalink / raw)
To: Spencer Oliver; +Cc: ecos-patches
Spencer Oliver wrote:
> cygwin: define PATH_MAX for host tools build
Wouldn't this be better in ecutils.cpp? It already has an ifdef __CYGWIN__
block for cygwin_conv_to_*_path() which is the same place PATH_MAX is used.
P.S. Don't forget a changelog entry.
Jifl
> ------------------------------------------------------------------------
>
> # HG changeset patch
> # User Spencer Oliver <spen@spen-soft.co.uk>
> # Date 1272975669 -3600
> # Node ID c0527a4c2b5e3f6fbe82ec4c3f7568e6caf17355
> # Parent c88d9f19de1aa679335bbec8b609e824d1fbd015
> cygwin: define PATH_MAX for host tools build
>
> diff -r c88d9f19de1a -r c0527a4c2b5e host/tools/Utils/common/eCosStd.h
> --- a/host/tools/Utils/common/eCosStd.h Tue May 04 13:19:54 2010 +0100
> +++ b/host/tools/Utils/common/eCosStd.h Tue May 04 13:21:09 2010 +0100
> @@ -52,6 +52,7 @@
>
> #include <malloc.h> // malloc
> #include <stdlib.h> // atoi
> + #include <limits.h> // PATH_MAX
> #include <errno.h>
> #define WOULDBLOCK WSAEWOULDBLOCK
>
--
------["The best things in life aren't things."]------ Opinions==mine
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cygwin: define PATH_MAX for host tools build
2010-05-12 13:09 ` Jonathan Larmour
@ 2010-05-12 15:06 ` John Dallaway
2010-05-12 16:31 ` Spencer Oliver
0 siblings, 1 reply; 6+ messages in thread
From: John Dallaway @ 2010-05-12 15:06 UTC (permalink / raw)
To: Spencer Oliver; +Cc: eCos Patches List
Hi Spencer
Jonathan Larmour wrote:
> Spencer Oliver wrote:
>
>> cygwin: define PATH_MAX for host tools build
>
> Wouldn't this be better in ecutils.cpp? It already has an ifdef
> __CYGWIN__ block for cygwin_conv_to_*_path() which is the same place
> PATH_MAX is used.
I've been unable to find a build issue for which this patch might be
required. Is there a specific eCos host tools source file which is
failing to build for you? Can you provide the relevant part of your
build log and the version of Cygwin that you are using please?
John Dallaway
eCos maintainer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cygwin: define PATH_MAX for host tools build
2010-05-12 15:06 ` John Dallaway
@ 2010-05-12 16:31 ` Spencer Oliver
2010-05-12 16:54 ` John Dallaway
0 siblings, 1 reply; 6+ messages in thread
From: Spencer Oliver @ 2010-05-12 16:31 UTC (permalink / raw)
To: John Dallaway; +Cc: eCos Patches List
On 12/05/2010 16:06, John Dallaway wrote:
> Hi Spencer
>
> Jonathan Larmour wrote:
>
>> Spencer Oliver wrote:
>>
>>> cygwin: define PATH_MAX for host tools build
>>
>> Wouldn't this be better in ecutils.cpp? It already has an ifdef
>> __CYGWIN__ block for cygwin_conv_to_*_path() which is the same place
>> PATH_MAX is used.
>
> I've been unable to find a build issue for which this patch might be
> required. Is there a specific eCos host tools source file which is
> failing to build for you? Can you provide the relevant part of your
> build log and the version of Cygwin that you are using please?
>
using cygwin 1.7.1 gcc 4.4.3
issue is when building configtool
c++ -O2 -c -ITCLDIR_use_system/include
-I/cygdrive/c/ecos/configtool/build/tools/include
-I/cygdrive/c/ecos/ecos.hg/host/tools/configtool/common/common
-I/cygdrive/c/ecos/ecos.hg/host/tools/Utils/common
-I/cygdrive/c/ecos/ecos.hg/host/tools/ecostest/common
-DecUSE_EXPERIMENTAL_CODE=1
`/cygdrive/c/ecos/configtool/build/wxlib/bin/wx-config --cppflags`
-D_WIN32 -D__WIN32__ -DSTRICT -D__USE_W32_SOCKETS -o
/cygdrive/c/ecos/configtool/build/configtool-build/eCosTestPlatform.o
/cygdrive/c/ecos/ecos.hg/host/tools/ecostest/common/eCosTestPlatform.cpp
/cygdrive/c/ecos/ecos.hg/host/tools/ecostest/common/eCosTestPlatform.cpp: In
static member function ‘static bool CeCosTestPlatform::LoadFromDir(const
char*)Â’:
/cygdrive/c/ecos/ecos.hg/host/tools/ecostest/common/eCosTestPlatform.cpp:61:
error: ‘PATH_MAX’ was not declared in this scope
/cygdrive/c/ecos/ecos.hg/host/tools/ecostest/common/eCosTestPlatform.cpp:62:
error: ‘szOrigDir’ was not declared in this scope
make: ***
[/cygdrive/c/ecos/configtool/build/configtool-build/eCosTestPlatform.o]
Error 1
Cheers
Spen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cygwin: define PATH_MAX for host tools build
2010-05-12 16:31 ` Spencer Oliver
@ 2010-05-12 16:54 ` John Dallaway
2010-05-13 13:43 ` Jonathan Larmour
0 siblings, 1 reply; 6+ messages in thread
From: John Dallaway @ 2010-05-12 16:54 UTC (permalink / raw)
To: Spencer Oliver; +Cc: eCos Patches List
Spencer Oliver wrote:
> On 12/05/2010 16:06, John Dallaway wrote:
>> Hi Spencer
>>
>> Jonathan Larmour wrote:
>>
>>> Spencer Oliver wrote:
>>>
>>>> cygwin: define PATH_MAX for host tools build
>>>
>>> Wouldn't this be better in ecutils.cpp? It already has an ifdef
>>> __CYGWIN__ block for cygwin_conv_to_*_path() which is the same place
>>> PATH_MAX is used.
>>
>> I've been unable to find a build issue for which this patch might be
>> required. Is there a specific eCos host tools source file which is
>> failing to build for you? Can you provide the relevant part of your
>> build log and the version of Cygwin that you are using please?
>>
>
> using cygwin 1.7.1 gcc 4.4.3
> issue is when building configtool
It looks like this may be related to the gcc4 package. There are no
build problems with gcc 3.4.4 and recent Cygwin. I will investigate...
John Dallaway
eCos maintainer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cygwin: define PATH_MAX for host tools build
2010-05-12 16:54 ` John Dallaway
@ 2010-05-13 13:43 ` Jonathan Larmour
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Larmour @ 2010-05-13 13:43 UTC (permalink / raw)
To: John Dallaway; +Cc: Spencer Oliver, eCos Patches List
On 12/05/10 17:54, John Dallaway wrote:
> Spencer Oliver wrote:
>
>> On 12/05/2010 16:06, John Dallaway wrote:
>>> Hi Spencer
>>>
>>> Jonathan Larmour wrote:
>>>
>>>> Spencer Oliver wrote:
>>>>
>>>>> cygwin: define PATH_MAX for host tools build
>>>>
>>>> Wouldn't this be better in ecutils.cpp? It already has an ifdef
>>>> __CYGWIN__ block for cygwin_conv_to_*_path() which is the same place
>>>> PATH_MAX is used.
>>>
>>> I've been unable to find a build issue for which this patch might be
>>> required. Is there a specific eCos host tools source file which is
>>> failing to build for you? Can you provide the relevant part of your
>>> build log and the version of Cygwin that you are using please?
>>>
>>
>> using cygwin 1.7.1 gcc 4.4.3
>> issue is when building configtool
>
> It looks like this may be related to the gcc4 package. There are no
> build problems with gcc 3.4.4 and recent Cygwin. I will investigate...
FWIW he's clearly right that if you use PATH_MAX you should be
#include'ing <limits.h>.
Jifl
--
--["No sense being pessimistic, it wouldn't work anyway"]-- Opinions==mine
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-05-13 13:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-05-04 12:27 [PATCH] cygwin: define PATH_MAX for host tools build Spencer Oliver
2010-05-12 13:09 ` Jonathan Larmour
2010-05-12 15:06 ` John Dallaway
2010-05-12 16:31 ` Spencer Oliver
2010-05-12 16:54 ` John Dallaway
2010-05-13 13:43 ` Jonathan Larmour
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).