From: "Lambrecht Jürgen" <J.Lambrecht@TELEVIC.com>
To: "ecos-patches@ecos.sourceware.org" <ecos-patches@ecos.sourceware.org>
Subject: [PATCH] The DHCPREQUEST message should contain the same 'xid' as the DHCPOFFER message
Date: Wed, 12 Feb 2014 13:08:00 -0000 [thread overview]
Message-ID: <52FB723E.2080900@televic.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
Hi,
I found a bug and fixed it, so I don't know if I need to use bugzilla
for that?
In attach the patch.
file: net/common/current/src/dhcp_prot.c
According to RFC 2131 (http://www.faqs.org/rfcs/rfc2131.html): "The
DHCPREQUEST message contains the same 'xid' as the DHCPOFFER message."
So in a DHCP DORA cycle (Discover-Offer-Request-Acknowledge) the same
transaction ID should be used ('xid' in C code).
We never had problems with that, but now we have a strict customer..
Kind regards,
Jürgen
--
Jürgen Lambrecht
R&D Associate
Mobile: +32 499 644 531
Tel: +32 (0)51 303045 Fax: +32 (0)51 310670
http://www.televic-rail.com
Televic Rail NV - Leo Bekaertlaan 1 - 8870 Izegem - Belgium
Company number 0825.539.581 - RPR Kortrijk
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dhcp_prot.patch --]
[-- Type: text/x-patch; name="dhcp_prot.patch", Size: 1192 bytes --]
Index: net/common/current/src/dhcp_prot.c
===================================================================
RCS file: /cvs/ecos/ecos-opt/net/net/common/current/src/dhcp_prot.c,v
retrieving revision 1.23
diff -u -5 -p -r1.23 dhcp_prot.c
--- net/common/current/src/dhcp_prot.c 11 Mar 2011 20:00:20 -0000 1.23
+++ net/common/current/src/dhcp_prot.c 12 Feb 2014 12:26:46 -0000
@@ -926,11 +926,12 @@ do_dhcp(const char *intf, struct bootp *
// Save the good packet in *xmit
bcopy( received, xmit, dhcp_size(received) );
// we like the packet, so reset the timeout for next time
reset_timeout( &tv, &timeout_scratch );
*pstate = DHCPSTATE_REQUESTING;
- NEW_XID( xid ); // Happy to advance, so new XID
+ // *no* new XID: The DHCPREQUEST message contains the same
+ // 'xid' as the DHCPOFFER message (http://www.faqs.org/rfcs/rfc2131.html).
}
}
else // No TAG_DHCP_MESS_TYPE entry so it's a bootp reply
seen_bootp_reply = 1; // (keep the bootp packet in received)
next reply other threads:[~2014-02-12 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 13:08 Lambrecht Jürgen [this message]
2014-02-12 14:32 ` Michael Jones
2014-02-15 0:03 ` "Ilija Kocho [Илија Кочо]"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FB723E.2080900@televic.com \
--to=j.lambrecht@televic.com \
--cc=ecos-patches@ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).