From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17141 invoked by alias); 12 Feb 2014 13:08:25 -0000 Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org Received: (qmail 17127 invoked by uid 89); 12 Feb 2014 13:08:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_50,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: ip2.televic.com Received: from ip2.televic.com (HELO ip2.televic.com) (81.82.194.222) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2014 13:08:22 +0000 Received: from SRV-VS06.TELEVIC.COM ([10.0.0.46]) by SRV-VS06.TELEVIC.COM ([10.0.0.46]) with mapi; Wed, 12 Feb 2014 14:08:14 +0100 From: =?iso-8859-1?Q?Lambrecht_J=FCrgen?= To: "ecos-patches@ecos.sourceware.org" Date: Wed, 12 Feb 2014 13:08:00 -0000 Subject: [PATCH] The DHCPREQUEST message should contain the same 'xid' as the DHCPOFFER message Message-ID: <52FB723E.2080900@televic.com> user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 Content-Type: multipart/mixed; boundary="_002_52FB723E2080900televiccom_" MIME-Version: 1.0 X-SW-Source: 2014-02/txt/msg00002.txt.bz2 --_002_52FB723E2080900televiccom_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 752 Hi, I found a bug and fixed it, so I don't know if I need to use bugzilla=20 for that? In attach the patch. file: net/common/current/src/dhcp_prot.c According to RFC 2131 (http://www.faqs.org/rfcs/rfc2131.html): "The=20 DHCPREQUEST message contains the same 'xid' as the DHCPOFFER message." So in a DHCP DORA cycle (Discover-Offer-Request-Acknowledge) the same=20 transaction ID should be used ('xid' in C code). We never had problems with that, but now we have a strict customer.. Kind regards, J=FCrgen --=20 J=FCrgen Lambrecht R&D Associate Mobile: +32 499 644 531 Tel: +32 (0)51 303045 Fax: +32 (0)51 310670 http://www.televic-rail.com Televic Rail NV - Leo Bekaertlaan 1 - 8870 Izegem - Belgium Company number 0825.539.581 - RPR Kortrijk --_002_52FB723E2080900televiccom_ Content-Type: text/x-patch; name="dhcp_prot.patch" Content-Description: dhcp_prot.patch Content-Disposition: attachment; filename="dhcp_prot.patch"; size=1192; creation-date="Wed, 12 Feb 2014 13:08:14 GMT"; modification-date="Wed, 12 Feb 2014 13:08:14 GMT" Content-Transfer-Encoding: base64 Content-length: 1619 SW5kZXg6IG5ldC9jb21tb24vY3VycmVudC9zcmMvZGhjcF9wcm90LmMNCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3ZzL2Vjb3MvZWNv cy1vcHQvbmV0L25ldC9jb21tb24vY3VycmVudC9zcmMvZGhjcF9wcm90LmMs dg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjIzDQpkaWZmIC11IC01IC1wIC1y MS4yMyBkaGNwX3Byb3QuYw0KLS0tIG5ldC9jb21tb24vY3VycmVudC9zcmMv ZGhjcF9wcm90LmMJMTEgTWFyIDIwMTEgMjA6MDA6MjAgLTAwMDAJMS4yMw0K KysrIG5ldC9jb21tb24vY3VycmVudC9zcmMvZGhjcF9wcm90LmMJMTIgRmVi IDIwMTQgMTI6MjY6NDYgLTAwMDANCkBAIC05MjYsMTEgKzkyNiwxMiBAQCBk b19kaGNwKGNvbnN0IGNoYXIgKmludGYsIHN0cnVjdCBib290cCAqDQogICAg ICAgICAgICAgICAgICAgICAvLyBTYXZlIHRoZSBnb29kIHBhY2tldCBpbiAq eG1pdA0KICAgICAgICAgICAgICAgICAgICAgYmNvcHkoIHJlY2VpdmVkLCB4 bWl0LCBkaGNwX3NpemUocmVjZWl2ZWQpICk7DQogICAgICAgICAgICAgICAg ICAgICAvLyB3ZSBsaWtlIHRoZSBwYWNrZXQsIHNvIHJlc2V0IHRoZSB0aW1l b3V0IGZvciBuZXh0IHRpbWUNCiAgICAgICAgICAgICAgICAgICAgIHJlc2V0 X3RpbWVvdXQoICZ0diwgJnRpbWVvdXRfc2NyYXRjaCApOw0KICAgICAgICAg ICAgICAgICAgICAgKnBzdGF0ZSA9IERIQ1BTVEFURV9SRVFVRVNUSU5HOw0K LSAgICAgICAgICAgICAgICAgICAgTkVXX1hJRCggeGlkICk7IC8vIEhhcHB5 IHRvIGFkdmFuY2UsIHNvIG5ldyBYSUQNCisJCSAgICAvLyAqbm8qIG5ldyBY SUQ6IFRoZSBESENQUkVRVUVTVCBtZXNzYWdlIGNvbnRhaW5zIHRoZSBzYW1l DQorCQkgICAgLy8gJ3hpZCcgYXMgdGhlIERIQ1BPRkZFUiBtZXNzYWdlICho dHRwOi8vd3d3LmZhcXMub3JnL3JmY3MvcmZjMjEzMS5odG1sKS4gDQogICAg ICAgICAgICAgICAgIH0NCiAgICAgICAgICAgICB9DQogICAgICAgICAgICAg ZWxzZSAvLyBObyBUQUdfREhDUF9NRVNTX1RZUEUgZW50cnkgc28gaXQncyBh IGJvb3RwIHJlcGx5DQogICAgICAgICAgICAgICAgIHNlZW5fYm9vdHBfcmVw bHkgPSAxOyAvLyAoa2VlcCB0aGUgYm9vdHAgcGFja2V0IGluIHJlY2VpdmVk KQ0KICAgICAgICAgICAgICAgICANCg== --_002_52FB723E2080900televiccom_--